Skip to content

Commit f64c1c2

Browse files
laipz8200刘江波
authored and
刘江波
committed
fix(api/ops_trace): avoid raise exception directly (langgenius#11732)
Signed-off-by: -LAN- <[email protected]>
1 parent 5edeb5a commit f64c1c2

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

api/controllers/console/app/model_config.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def post(self, app_model):
6565
provider_type=agent_tool_entity.provider_type,
6666
identity_id=f"AGENT.{app_model.id}",
6767
)
68-
except Exception as e:
68+
except Exception:
6969
continue
7070

7171
# get decrypted parameters
@@ -97,7 +97,7 @@ def post(self, app_model):
9797
app_id=app_model.id,
9898
agent_tool=agent_tool_entity,
9999
)
100-
except Exception as e:
100+
except Exception:
101101
continue
102102

103103
manager = ToolParameterConfigurationManager(

api/controllers/console/app/ops_trace.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from flask_restful import Resource, reqparse
2+
from werkzeug.exceptions import BadRequest
23

34
from controllers.console import api
45
from controllers.console.app.error import TracingConfigCheckError, TracingConfigIsExist, TracingConfigNotExist
@@ -26,7 +27,7 @@ def get(self, app_id):
2627
return {"has_not_configured": True}
2728
return trace_config
2829
except Exception as e:
29-
raise e
30+
raise BadRequest(str(e))
3031

3132
@setup_required
3233
@login_required
@@ -48,7 +49,7 @@ def post(self, app_id):
4849
raise TracingConfigCheckError()
4950
return result
5051
except Exception as e:
51-
raise e
52+
raise BadRequest(str(e))
5253

5354
@setup_required
5455
@login_required
@@ -68,7 +69,7 @@ def patch(self, app_id):
6869
raise TracingConfigNotExist()
6970
return {"result": "success"}
7071
except Exception as e:
71-
raise e
72+
raise BadRequest(str(e))
7273

7374
@setup_required
7475
@login_required
@@ -85,7 +86,7 @@ def delete(self, app_id):
8586
raise TracingConfigNotExist()
8687
return {"result": "success"}
8788
except Exception as e:
88-
raise e
89+
raise BadRequest(str(e))
8990

9091

9192
api.add_resource(TraceAppConfigApi, "/apps/<uuid:app_id>/trace-config")

api/controllers/console/datasets/datasets_document.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -948,7 +948,7 @@ def post(self, dataset_id):
948948
if document.indexing_status == "completed":
949949
raise DocumentAlreadyFinishedError()
950950
retry_documents.append(document)
951-
except Exception as e:
951+
except Exception:
952952
logging.exception(f"Failed to retry document, document id: {document_id}")
953953
continue
954954
# retry document

0 commit comments

Comments
 (0)