feat(utils): handle opening multiple notes

Author: jghauser

lua/papis/utils.lua

@@ -7,7 +7,6 @@
 
 local NuiLine = require("nui.line")
 local NuiPopup = require("nui.popup")
-local nuiEvent = require("nui.utils.autocmd").event
 local Path = require("pathlib")
 
 local new_timer = vim.uv.new_timer
@@ -110,7 +109,18 @@ function M:do_open_attached_files(papis_id)
   end
 end
 
-local popups = {}
+local popup
+local file_queue = {}
+
+-- Function to be called when a popup is closed
+function M:on_popup_close()
+  -- If there are no more active popups, open the files in the queue
+  if (not popup) and (#file_queue > 0) then
+    self:do_open_text_file(unpack(file_queue[1]))
+    table.remove(file_queue, 1)
+  end
+end
+
 ---Opens a text file with neovim, asking to select one if there are multiple buf_options
 ---@param papis_id string #The `papis_id` of the entry
 ---@param type string #Either "note" or "info", specifying the type of file
@@ -129,6 +139,8 @@ function M:do_open_text_file(papis_id, type)
     log.debug("Opening a note")
     if entry.notes then
       cmd = string.format("edit %s", entry.notes[1])
+      popup = nil
+      self:on_popup_close()
     else
       local lines_text = {
         { "This entry has no notes.", "WarningMsg" },
@@ -138,8 +150,14 @@ function M:do_open_text_file(papis_id, type)
       for _, line in pairs(lines_text) do
         width = math.max(width, #line[1])
       end
-      local current_popup = #popups + 1
-      popups[current_popup] = NuiPopup({
+
+      -- If there are active popups, add the file to the queue and return
+      if popup then
+        table.insert(file_queue, { papis_id, type })
+        return
+      end
+
+      popup = NuiPopup({
         enter = true,
         position = "50%",
         size = {
@@ -156,9 +174,8 @@ function M:do_open_text_file(papis_id, type)
         },
       })
 
-      popups[current_popup]:map("n", { "Y", "y", "<cr>" }, function(_)
-        popups[current_popup]:unmount()
-        popups[current_popup] = nil
+      popup:map("n", { "Y", "y", "<cr>" }, function(_)
+        popup:unmount()
         local config = require("papis.config")
         local create_new_note_fn = config.create_new_note_fn
         local notes_name = db.config:get_conf_value("notes_name")
@@ -184,24 +201,21 @@ function M:do_open_text_file(papis_id, type)
           end)
         )
       end, { noremap = true, nowait = true })
-      popups[current_popup]:map("n", { "N", "n", "<esc>", "q" }, function(_)
-        popups[current_popup]:unmount()
-        popups[current_popup] = nil
-      end, { noremap = true, nowait = true })
 
-      popups[current_popup]:on({ nuiEvent.BufLeave }, function()
-        popups[current_popup]:unmount()
-        popups[current_popup] = nil
-      end, { once = true })
+      popup:map("n", { "N", "n", "<esc>", "q" }, function(_)
+        popup:unmount()
+        popup = nil
+        self:on_popup_close()
+      end, { noremap = true, nowait = true })
 
       for k, line in pairs(lines_text) do
         local nuiline = NuiLine()
         nuiline:append(unpack(line))
-        nuiline:render(popups[current_popup].bufnr, -1, k)
+        nuiline:render(popup.bufnr, -1, k)
       end
 
       vim.schedule(function()
-        popups[current_popup]:mount()
+        popup:mount()
       end)
     end
   elseif type == "info" then

lua/telescope/_extensions/papis/actions.lua

@@ -98,7 +98,6 @@ M.open_note = function(prompt_bufnr)
     utils:do_open_text_file(papis_id, "note")
   else
     for _, entry in pairs(multi) do
-      -- TODO: this only opens one note if a note needs to be created
       local papis_id = entry.id.papis_id
       utils:do_open_text_file(papis_id, "note")
     end