chore: Lint fixes

Author: jfyne

diff.go

@@ -121,7 +121,7 @@ func shapeTree(root *html.Node) {
 				break
 			}
 		}
-		if hasFlag == false {
+		if !hasFlag {
 			root.Attr = append(root.Attr, html.Attribute{Key: LiveRendered})
 		}
 	}
@@ -168,7 +168,7 @@ func (d *differ) compareNodes(oldNode, newNode *html.Node, followedPath []int) [
 	d.liveUpdateCheck(newNode, followedPath)
 
 	// If nodes at this position are not equal patch a replacement.
-	if nodeEqual(oldNode, newNode) == false {
+	if !nodeEqual(oldNode, newNode) {
 		return append(patches, d.generatePatch(newNode, followedPath, Replace))
 	}
 
@@ -301,10 +301,7 @@ func nodeEqual(oldNode *html.Node, newNode *html.Node) bool {
 		return false
 	}
 	// Data check
-	if strings.TrimSpace(oldNode.Data) != strings.TrimSpace(newNode.Data) {
-		return false
-	}
-	return true
+	return strings.TrimSpace(oldNode.Data) == strings.TrimSpace(newNode.Data)
 }
 
 // generateNodeList create a list of sibling nodes.

event_test.go

@@ -15,7 +15,7 @@ func TestEventParams(t *testing.T) {
 	}
 
 	e.Data = []byte("wrong")
-	p, err = e.Params()
+	_, err = e.Params()
 	if err != ErrMessageMalformed {
 		t.Error("expected ErrMessageMalformed, got", err)
 	}

handler.go

@@ -91,7 +91,7 @@ func NewHandler(store SessionStore, configs ...HandlerConfig) (*Handler, error)
 		Render: func(ctx context.Context, data interface{}) (io.Reader, error) {
 			return nil, ErrNoRenderer
 		},
-		Error: func(ctx context.Context, w http.ResponseWriter, r *http.Request, err error) {
+		Error: func(_ context.Context, w http.ResponseWriter, _ *http.Request, err error) {
 			w.WriteHeader(500)
 			w.Write([]byte(err.Error()))
 		},
@@ -115,7 +115,7 @@ func NewHandler(store SessionStore, configs ...HandlerConfig) (*Handler, error)
 // ServeHTTP serves this handler.
 func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	if r.URL.Path == "/favicon.ico" {
-		if h.ignoreFaviconRequest == true {
+		if h.ignoreFaviconRequest {
 			w.WriteHeader(404)
 			return
 		}
@@ -138,7 +138,6 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	// Upgrade to the webscoket version.
 	h.serveWS(w, r)
-	return
 }
 
 // Broadcast send a message to all sockets connected to this handler.

pubsub.go

@@ -47,7 +47,7 @@ func (p *PubSub) Subscribe(topic string, h *Handler) {
 
 	// This adjusts the handlers broadcast function to publish onto the
 	// given topic.
-	h.broadcast = func(ctx context.Context, h *Handler, msg Event) {
+	h.broadcast = func(ctx context.Context, _ *Handler, msg Event) {
 		if err := p.transport.Publish(ctx, topic, msg); err != nil {
 			log.Println("could not publish broadcast:", err)
 		}
@@ -71,7 +71,6 @@ type TransportMessage struct {
 // LocalTransport a pubsub transport that allows handlers to communicate
 // locally.
 type LocalTransport struct {
-	ctx   context.Context
 	queue chan TransportMessage
 }