Skip to content

Commit d90681f

Browse files
authored
Fix jf eot command output (#2961)
1 parent 449b4f1 commit d90681f

File tree

3 files changed

+12
-24
lines changed

3 files changed

+12
-24
lines changed

access_test.go

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ package main
33
import (
44
"encoding/json"
55
"fmt"
6+
"github.com/jfrog/jfrog-cli-core/v2/general/token"
67
"net/http"
78
"os"
8-
"regexp"
99
"testing"
1010

1111
"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils"
@@ -274,30 +274,18 @@ func TestAccessTokenCreate(t *testing.T) {
274274
func TestOidcExchangeToken(t *testing.T) {
275275
// If token ID was not provided by the CI, skip this test
276276
if os.Getenv(coreutils.OidcExchangeTokenId) == "" {
277-
t.Skip("No token ID available in environment,skipping test")
277+
t.Skip("No token ID available in environment, skipping test")
278278
return
279279
}
280280
accessCli = coreTests.NewJfrogCli(execMain, "jfrog", "")
281-
var testCases = []struct {
282-
name string
283-
args []string
284-
expectedOutput string
285-
}{
286-
{
287-
name: "Successful exchange",
288-
args: []string{"eot", "setup-jfrog-cli-test", "--url=https://ecosysjfrog.jfrog.io"},
289-
expectedOutput: `\{ AccessToken: [^\s]+ Username: [^\s]+ \}`,
290-
},
291-
}
292281

293-
for _, testCase := range testCases {
294-
t.Run(testCase.name, func(t *testing.T) {
295-
output := accessCli.RunCliCmdWithOutput(t, testCase.args...)
296-
matched, err := regexp.MatchString(testCase.expectedOutput, output)
297-
assert.NoError(t, err)
298-
assert.True(t, matched, "Output did not match expected pattern")
299-
})
300-
}
282+
output := accessCli.RunCliCmdWithOutput(t, "eot", "setup-jfrog-cli-test", "--url=https://ecosysjfrog.jfrog.io")
283+
var result token.ExchangeCommandOutputStruct
284+
err := json.Unmarshal([]byte(output), &result)
285+
assert.NoError(t, err, "Output should be valid JSON")
286+
assert.NotEmpty(t, result.AccessToken, "AccessToken should not be empty")
287+
assert.NotEmpty(t, result.Username, "Username should not be empty")
288+
301289
}
302290

303291
func assertNotEmptyIfExpected(t *testing.T, expected bool, output string) {

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ require (
189189
sigs.k8s.io/yaml v1.4.0 // indirect
190190
)
191191

192-
// replace github.com/jfrog/jfrog-cli-core/v2 => github.com/jfrog/jfrog-cli-core/v2 v2.31.1-0.20250410085750-f34f5feea93e
192+
replace github.com/jfrog/jfrog-cli-core/v2 => github.com/jfrog/jfrog-cli-core/v2 v2.31.1-0.20250505105213-0ba559a374cb
193193

194194
// replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.28.1-0.20250406105605-ee90d11546f9
195195

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ github.com/jfrog/jfrog-apps-config v1.0.1 h1:mtv6k7g8A8BVhlHGlSveapqf4mJfonwvXYL
188188
github.com/jfrog/jfrog-apps-config v1.0.1/go.mod h1:8AIIr1oY9JuH5dylz2S6f8Ym2MaadPLR6noCBO4C22w=
189189
github.com/jfrog/jfrog-cli-artifactory v0.2.4 h1:n/BlqkH20jW8T1JPr/QHw+D+wsPZsDU0Qq/+eSGzgAg=
190190
github.com/jfrog/jfrog-cli-artifactory v0.2.4/go.mod h1:tXlrvTtG4l0dPdKFG7nlteuSv7vggF/OVwsq44sgVgA=
191-
github.com/jfrog/jfrog-cli-core/v2 v2.58.4 h1:ywpq2UMOPtp9WcELR54HSJJS0PSgin9plM4If9sDks0=
192-
github.com/jfrog/jfrog-cli-core/v2 v2.58.4/go.mod h1:JbLdMCWL0xVZZ0FY7jd+iTi/gKYqRmRpeLBhAFtldfQ=
191+
github.com/jfrog/jfrog-cli-core/v2 v2.31.1-0.20250505105213-0ba559a374cb h1:rFO38OtQqjO2mO8cOQibQ0n+i/mMkh/QLq6Ss8fsJjg=
192+
github.com/jfrog/jfrog-cli-core/v2 v2.31.1-0.20250505105213-0ba559a374cb/go.mod h1:JbLdMCWL0xVZZ0FY7jd+iTi/gKYqRmRpeLBhAFtldfQ=
193193
github.com/jfrog/jfrog-cli-platform-services v1.9.0 h1:r/ETgJuMUOUu12w20ydsF6paqEaj0khH6bxMRsdNz1Y=
194194
github.com/jfrog/jfrog-cli-platform-services v1.9.0/go.mod h1:pMZMSwhj7yA4VKyj0Skr2lObIyGpZUxNJ40DSLKXU38=
195195
github.com/jfrog/jfrog-cli-security v1.17.1 h1:4gXZ9Q59DOBkntMBDjlcVdZ1jaJUn1bFy4Rhr+SAeqA=

0 commit comments

Comments
 (0)