Skip to content

Commit c7bcefb

Browse files
authored
expect: Improve report when matcher fails, part 16 (#8306)
* expect: Improve report when matcher fails, part 16 * Update CHANGELOG.md * Replace noun with verb: serializes to the same string
1 parent 1f280d8 commit c7bcefb

File tree

7 files changed

+313
-338
lines changed

7 files changed

+313
-338
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
### Features
44

55
- `[expect]` Improve report when matcher fails, part 15 ([#8281](https://github.com/facebook/jest/pull/8281))
6+
- `[expect]` Improve report when matcher fails, part 16 ([#8306](https://github.com/facebook/jest/pull/8306))
67
- `[jest-runner]` Pass docblock pragmas to TestEnvironment constructor ([#8320](https://github.com/facebook/jest/pull/8320))
78

89
### Fixes

e2e/__tests__/__snapshots__/failures.test.ts.snap

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ FAIL __tests__/testMacro.test.js
260260
261261
● use some imported macro to make assertion
262262
263-
expect(received).toEqual(expected)
263+
expect(received).toEqual(expected) // deep equality
264264
265265
Expected: 2
266266
Received: 1
@@ -286,9 +286,7 @@ FAIL __tests__/asyncFailures.test.js
286286
287287
● resolve, but fail
288288
289-
expect(received).toEqual(expected)
290-
291-
Difference:
289+
expect(received).resolves.toEqual(expected) // deep equality
292290
293291
- Expected
294292
+ Received
@@ -310,9 +308,7 @@ FAIL __tests__/asyncFailures.test.js
310308
311309
● reject, but fail
312310
313-
expect(received).toEqual(expected)
314-
315-
Difference:
311+
expect(received).rejects.toEqual(expected) // deep equality
316312
317313
- Expected
318314
+ Received

packages/expect/src/__tests__/__snapshots__/extend.test.js.snap

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`defines asymmetric unary matchers 1`] = `
4-
"<dim>expect(</><red>received</><dim>).toEqual(</><green>expected</><dim>)</>
5-
6-
Difference:
4+
"<dim>expect(</><red>received</><dim>).</>toEqual<dim>(</><green>expected</><dim>) // deep equality</>
75
86
<green>- Expected</>
97
<red>+ Received</>
@@ -15,9 +13,7 @@ Difference:
1513
`;
1614
1715
exports[`defines asymmetric unary matchers that can be prefixed by not 1`] = `
18-
"<dim>expect(</><red>received</><dim>).toEqual(</><green>expected</><dim>)</>
19-
20-
Difference:
16+
"<dim>expect(</><red>received</><dim>).</>toEqual<dim>(</><green>expected</><dim>) // deep equality</>
2117
2218
<green>- Expected</>
2319
<red>+ Received</>
@@ -29,9 +25,7 @@ Difference:
2925
`;
3026
3127
exports[`defines asymmetric variadic matchers 1`] = `
32-
"<dim>expect(</><red>received</><dim>).toEqual(</><green>expected</><dim>)</>
33-
34-
Difference:
28+
"<dim>expect(</><red>received</><dim>).</>toEqual<dim>(</><green>expected</><dim>) // deep equality</>
3529
3630
<green>- Expected</>
3731
<red>+ Received</>
@@ -43,9 +37,7 @@ Difference:
4337
`;
4438
4539
exports[`defines asymmetric variadic matchers that can be prefixed by not 1`] = `
46-
"<dim>expect(</><red>received</><dim>).toEqual(</><green>expected</><dim>)</>
47-
48-
Difference:
40+
"<dim>expect(</><red>received</><dim>).</>toEqual<dim>(</><green>expected</><dim>) // deep equality</>
4941
5042
<green>- Expected</>
5143
<red>+ Received</>

0 commit comments

Comments
 (0)