changes method of determining builtin modules to include missing builtins (#4740)

Author: CNDW

packages/jest-resolve/package.json

@@ -9,8 +9,7 @@
   "main": "build/index.js",
   "dependencies": {
     "browser-resolve": "^1.11.2",
-    "chalk": "^2.0.1",
-    "is-builtin-module": "^1.0.0"
+    "chalk": "^2.0.1"
   },
   "devDependencies": {
     "jest-haste-map": "^21.2.0"

packages/jest-resolve/src/__tests__/is_builtin_module.test.js

@@ -0,0 +1,19 @@
+const isBuiltinModule = require('../is_builtin_module');
+
+describe('isBuiltinModule', () => {
+  it('should return true for the `path` module', () => {
+    expect(isBuiltinModule('path')).toBe(true);
+  });
+
+  it('should return false for the `chalk` module', () => {
+    expect(isBuiltinModule('chalk')).toBe(false);
+  });
+
+  it('should return true for the `_http_common` module', () => {
+    expect(isBuiltinModule('_http_common')).toBe(true);
+  });
+
+  it('should return false for any internal node builtins', () => {
+    expect(isBuiltinModule('internal/http')).toBe(false);
+  });
+});

packages/jest-resolve/src/default_resolver.js

@@ -42,7 +42,7 @@ type ErrorWithCode = Error & {code?: string};
 
 import fs from 'fs';
 import path from 'path';
-import isBuiltinModule from 'is-builtin-module';
+import isBuiltinModule from './is_builtin_module';
 
 import nodeModulesPaths from './node_modules_paths';
 

packages/jest-resolve/src/index.js

@@ -14,7 +14,7 @@ import type {ResolveModuleConfig} from 'types/Resolve';
 import fs from 'fs';
 import path from 'path';
 import nodeModulesPaths from './node_modules_paths';
-import isBuiltinModule from 'is-builtin-module';
+import isBuiltinModule from './is_builtin_module';
 import defaultResolver from './default_resolver.js';
 import chalk from 'chalk';
 

packages/jest-resolve/src/is_builtin_module.js

@@ -0,0 +1,11 @@
+declare var process: {
+  binding(type: string): {},
+};
+
+const BUILTIN_MODULES = Object.keys(process.binding('natives')).filter(
+  (module: string) => !/^internal\//.test(module),
+);
+
+module.exports = function isBuiltinModule(module: string): boolean {
+  return BUILTIN_MODULES.indexOf(module) !== -1;
+};