Use FORCE_COLOR=0 for all tests

This change ensures that the tests work regardless of the value of
FORCE_COLOR environment variable. There are environments where this
variable is set to 1 and the tests fail. For example the tests fail when
they are run from Jetbrains IDEs (Webstorm, Rubymine and etc).

Author: hron

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Chore & Maintenance
 
 - `[website]` Switch domain to https://jestjs.io ([#6549](https://github.com/facebook/jest/pull/6549))
+- `[tests]` Free tests from the dependency on value of FORCE_COLOR ([#6585](https://github.com/facebook/jest/pull/6585/files))
 
 ## 23.2.0
 

e2e/__tests__/coverage_report.test.js

@@ -16,7 +16,9 @@ const runJest = require('../runJest');
 const DIR = path.resolve(__dirname, '../coverage-report');
 
 test('outputs coverage report', () => {
-  const {stdout, status} = runJest(DIR, ['--no-cache', '--coverage']);
+  const {stdout, status} = runJest(DIR, ['--no-cache', '--coverage'], {
+    stripAnsi: true,
+  });
   const coverageDir = path.resolve(__dirname, '../coverage-report/coverage');
 
   // - the `setup.js` file is ignored and should not be in the coverage report.
@@ -31,39 +33,51 @@ test('outputs coverage report', () => {
 });
 
 test('collects coverage only from specified file', () => {
-  const {stdout} = runJest(DIR, [
-    '--no-cache',
-    '--coverage',
-    '--collectCoverageFrom', // overwrites the one in package.json
-    'setup.js',
-  ]);
+  const {stdout} = runJest(
+    DIR,
+    [
+      '--no-cache',
+      '--coverage',
+      '--collectCoverageFrom', // overwrites the one in package.json
+      'setup.js',
+    ],
+    {stripAnsi: true},
+  );
 
   // Coverage report should only have `setup.js` coverage info
   expect(stdout).toMatchSnapshot();
 });
 
 test('collects coverage only from multiple specified files', () => {
-  const {stdout} = runJest(DIR, [
-    '--no-cache',
-    '--coverage',
-    '--collectCoverageFrom',
-    'setup.js',
-    '--collectCoverageFrom',
-    'OtherFile.js',
-  ]);
+  const {stdout} = runJest(
+    DIR,
+    [
+      '--no-cache',
+      '--coverage',
+      '--collectCoverageFrom',
+      'setup.js',
+      '--collectCoverageFrom',
+      'OtherFile.js',
+    ],
+    {stripAnsi: true},
+  );
 
   expect(stdout).toMatchSnapshot();
 });
 
 test('collects coverage only from specified files avoiding dependencies', () => {
-  const {stdout} = runJest(DIR, [
-    '--no-cache',
-    '--coverage',
-    '--collectCoverageOnlyFrom',
-    'Sum.js',
-    '--',
-    'Sum.test.js',
-  ]);
+  const {stdout} = runJest(
+    DIR,
+    [
+      '--no-cache',
+      '--coverage',
+      '--collectCoverageOnlyFrom',
+      'Sum.js',
+      '--',
+      'Sum.test.js',
+    ],
+    {stripAnsi: true},
+  );
 
   // Coverage report should only have `sum.js` coverage info
   expect(stdout).toMatchSnapshot();
@@ -106,7 +120,7 @@ test('collects coverage from duplicate files avoiding shared cache', () => {
   runJest(DIR, args);
 
   // Run for the second time
-  const {stdout, status} = runJest(DIR, args);
+  const {stdout, status} = runJest(DIR, args, {stripAnsi: true});
   expect(stdout).toMatchSnapshot();
   expect(status).toBe(0);
 });

e2e/__tests__/coverage_threshold.test.js

@@ -44,7 +44,9 @@ test('exits with 1 if coverage threshold is not met', () => {
     'package.json': JSON.stringify(pkgJson, null, 2),
   });
 
-  const {stdout, status} = runJest(DIR, ['--coverage', '--ci=false']);
+  const {stdout, status} = runJest(DIR, ['--coverage', '--ci=false'], {
+    stripAnsi: true,
+  });
   expect(status).toBe(1);
   expect(stdout).toMatchSnapshot();
 });

e2e/__tests__/find_related_files.test.js

@@ -64,7 +64,7 @@ describe('--findRelatedTests flag', () => {
     let stdout;
     let stderr;
 
-    ({stdout, stderr} = runJest(DIR));
+    ({stdout, stderr} = runJest(DIR, [], {stripAnsi: true}));
     let summary;
     let rest;
     ({summary, rest} = extractSummary(stderr));
@@ -80,7 +80,9 @@ describe('--findRelatedTests flag', () => {
     // both a.js and b.js should be in the coverage
     expect(stdout).toMatchSnapshot();
 
-    ({stdout, stderr} = runJest(DIR, ['--findRelatedTests', 'a.js']));
+    ({stdout, stderr} = runJest(DIR, ['--findRelatedTests', 'a.js'], {
+      stripAnsi: true,
+    }));
 
     ({summary, rest} = extractSummary(stderr));
 

e2e/__tests__/module_name_mapper.test.js

@@ -20,7 +20,9 @@ test('moduleNameMapper wrong configuration', () => {
 });
 
 test('moduleNameMapper correct configuration', () => {
-  const {stderr, status} = runJest('module-name-mapper-correct-config');
+  const {stderr, status} = runJest('module-name-mapper-correct-config', [], {
+    stripAnsi: true,
+  });
   const {rest} = extractSummary(stderr);
 
   expect(status).toBe(0);

e2e/__tests__/transform.test.js

@@ -33,7 +33,9 @@ describe('babel-jest', () => {
   });
 
   it('instruments only specific files and collects coverage', () => {
-    const {stdout} = runJest(dir, ['--coverage', '--no-cache']);
+    const {stdout} = runJest(dir, ['--coverage', '--no-cache'], {
+      stripAnsi: true,
+    });
     expect(stdout).toMatch('Covered.js');
     expect(stdout).not.toMatch('NotCovered.js');
     expect(stdout).not.toMatch('ExcludedFromCoverage.js');
@@ -63,11 +65,11 @@ describe('no babel-jest', () => {
   });
 
   test('instrumentation with no babel-jest', () => {
-    const {stdout} = runJest(tempDir, [
-      '--no-cache',
-      '--coverage',
-      '--no-watchman',
-    ]);
+    const {stdout} = runJest(
+      tempDir,
+      ['--no-cache', '--coverage', '--no-watchman'],
+      {stripAnsi: true},
+    );
     expect(stdout).toMatch('Covered.js');
     expect(stdout).not.toMatch('ExcludedFromCoverage.js');
     // coverage result should not change
@@ -92,7 +94,9 @@ describe('custom transformer', () => {
   });
 
   it('instruments files', () => {
-    const {stdout, status} = runJest(dir, ['--no-cache', '--coverage']);
+    const {stdout, status} = runJest(dir, ['--no-cache', '--coverage'], {
+      stripAnsi: true,
+    });
     // coverage should be empty because there's no real instrumentation
     expect(stdout).toMatchSnapshot();
     expect(status).toBe(0);

e2e/__tests__/typescript_coverage.test.js

@@ -14,6 +14,8 @@ const runJest = require('../runJest');
 it('instruments and collects coverage for typescript files', () => {
   const dir = path.resolve(__dirname, '../typescript-coverage');
   run('yarn', dir);
-  const {stdout} = runJest(dir, ['--coverage', '--no-cache']);
+  const {stdout} = runJest(dir, ['--coverage', '--no-cache'], {
+    stripAnsi: true,
+  });
   expect(stdout).toMatchSnapshot();
 });

e2e/runJest.js

@@ -12,6 +12,7 @@ const path = require('path');
 const fs = require('fs');
 const execa = require('execa');
 const {Writable} = require('readable-stream');
+const stripAnsi = require('strip-ansi');
 const {normalizeIcons} = require('./Utils');
 
 const {sync: spawnSync} = execa;
@@ -21,6 +22,7 @@ const JEST_PATH = path.resolve(__dirname, '../packages/jest-cli/bin/jest.js');
 type RunJestOptions = {
   nodePath?: string,
   skipPkgJsonCheck?: boolean, // don't complain if can't find package.json
+  stripAnsi?: boolean, // remove colors from stdout and stderr
 };
 
 // return the result of the spawned process:
@@ -49,13 +51,8 @@ function runJest(
     );
   }
 
-  const env = options.nodePath
-    ? Object.assign({}, process.env, {
-        FORCE_COLOR: 0,
-        NODE_PATH: options.nodePath,
-      })
-    : process.env;
-
+  const env = Object.assign({}, process.env, {FORCE_COLOR: 0});
+  if (options.nodePath) env['NODE_PATH'] = options.nodePath;
   const result = spawnSync(JEST_PATH, args || [], {
     cwd: dir,
     env,
@@ -66,7 +63,9 @@ function runJest(
   result.status = result.code;
 
   result.stdout = normalizeIcons(result.stdout);
+  if (options.stripAnsi) result.stdout = stripAnsi(result.stdout);
   result.stderr = normalizeIcons(result.stderr);
+  if (options.stripAnsi) result.stderr = stripAnsi(result.stderr);
 
   return result;
 }
@@ -118,12 +117,8 @@ runJest.until = async function(
     );
   }
 
-  const env = options.nodePath
-    ? Object.assign({}, process.env, {
-        FORCE_COLOR: 0,
-        NODE_PATH: options.nodePath,
-      })
-    : process.env;
+  const env = Object.assign({}, process.env, {FORCE_COLOR: 0});
+  if (options.nodePath) env['NODE_PATH'] = options.nodePath;
 
   const jestPromise = execa(JEST_PATH, args || [], {
     cwd: dir,
@@ -151,7 +146,9 @@ runJest.until = async function(
   result.status = result.code;
 
   result.stdout = normalizeIcons(result.stdout);
+  if (options.stripAnsi) result.stdout = stripAnsi(result.stdout);
   result.stderr = normalizeIcons(result.stderr);
+  if (options.stripAnsi) result.stderr = stripAnsi(result.stderr);
 
   return result;
 };