[JENKINS-74898] Avoid un-necessary TransientActionFactory consults (SonarSource#306)

Author: Dohbedoh

src/main/java/hudson/plugins/sonar/action/SonarBuildBadgeActionFactory.java

@@ -31,6 +31,11 @@
 @Extension
 public class SonarBuildBadgeActionFactory extends TransientActionFactory<Run> {
 
+  @Override
+  public Class<? extends Action> actionType() {
+    return SonarBuildBadgeAction.class;
+  }
+
   @Override
   public Class<Run> type() {
     return Run.class;

src/main/java/hudson/plugins/sonar/action/SonarProjectActionFactory.java

@@ -51,6 +51,11 @@ public SonarProjectActionFactory() {
     resolver = new SQProjectResolver(new HttpClient(OkHttpClientSingleton.getInstance()));
   }
 
+  @Override
+  public Class<? extends Action> actionType() {
+    return ProminentProjectAction.class;
+  }
+
   @Override
   public Class<Job> type() {
     return Job.class;
@@ -66,7 +71,7 @@ public Collection<? extends Action> createFor(Job project) {
     Run<?, ?> lastBuild = project.getLastCompletedBuild();
 
     if (lastBuild != null) {
-      for (SonarAnalysisAction a : lastBuild.getActions(SonarAnalysisAction.class)) {
+      for (SonarAnalysisAction a : SonarUtils.getPersistentActions(lastBuild, SonarAnalysisAction.class)) {
         if (a.getUrl() != null && !urls.contains(a.getUrl())) {
           urls.add(a.getUrl());
           sonarProjectActions.add(new SonarProjectIconAction(a));

src/test/java/hudson/plugins/sonar/action/SonarProjectActionFactoryTest.java

@@ -133,7 +133,7 @@ private void mockProject(boolean markProject, SonarAnalysisAction... buildInfos)
     when(project.getLastCompletedBuild()).thenReturn(build);
 
     if (markProject) {
-      when(build.getActions(SonarAnalysisAction.class)).thenReturn(Arrays.asList(buildInfos));
+      when(build.getActions()).thenReturn(Arrays.asList(buildInfos));
       when(project.getActions()).thenReturn(Collections.singletonList(new SonarMarkerAction()));
     }
   }