Skip to content

Integration Tests - Use default credential chain not requiring SA #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gbhat618 opened this issue Jan 2, 2025 · 2 comments
Open

Integration Tests - Use default credential chain not requiring SA #497

gbhat618 opened this issue Jan 2, 2025 · 2 comments

Comments

@gbhat618
Copy link
Contributor

gbhat618 commented Jan 2, 2025

Currently the integration tests expect to create a service account and export it to environment variables

GOOGLE_CREDENTIALS_FILE or GOOGLE_CREDENTIALS
GOOGLE_SA_NAME

it is bad practice and should try to use the default credentials instead.

Currently simply using the default credential path ~/.config/gcloud/application_default_credentials.json is not working - need to make appropriate changes to the credential reading and test automations.

See https://github.com/jenkinsci/google-compute-engine-plugin/pull/495/files/79b8ffdb9a7ad456b7ea013e88802f2ea3cd1046#r1895805984

@gbhat618 gbhat618 mentioned this issue Jan 2, 2025
6 tasks
@gbhat618
Copy link
Contributor Author

gbhat618 commented Jan 2, 2025

when credentialsId==null get the credential by getApplicationDefault

@gbhat618
Copy link
Contributor Author

gbhat618 commented Jan 2, 2025

Also as noted in here #495 (comment)
create new issue as per the status of client library and possibility to change to a better maintained client library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant