Fix sessionFixation test

jkakavas · jkakavas · commit 962a063c684b · 2019-01-14T08:16:08.000+02:00
diff --git a/src/test/java/org/jenkinsci/plugins/GithubAccessTokenPropertySEC797Test.java b/src/test/java/org/jenkinsci/plugins/GithubAccessTokenPropertySEC797Test.java
@@ -249,7 +249,8 @@ private void onUserTeams(HttpServletRequest req, HttpServletResponse resp) throw
         
         private void onLoginOAuthAuthorize(HttpServletRequest req, HttpServletResponse resp) throws IOException {
             String code = "test";
-            resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code);
+            String state = req.getParameter("state");
+            resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code + "&state=" + state);
         }
         
         private void onLoginOAuthAccessToken(HttpServletRequest req, HttpServletResponse resp) throws IOException {
diff --git a/src/test/java/org/jenkinsci/plugins/GithubAccessTokenPropertyTest.java b/src/test/java/org/jenkinsci/plugins/GithubAccessTokenPropertyTest.java
@@ -246,7 +246,7 @@ private void onUserTeams(HttpServletRequest req, HttpServletResponse resp) throw
         private void onLoginOAuthAuthorize(HttpServletRequest req, HttpServletResponse resp) throws IOException {
             String code = "test";
             String state = req.getParameter("state");
-            resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code+"&state="+state);
+            resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code + "&state=" + state);
         }
 
         private void onLoginOAuthAccessToken(HttpServletRequest req, HttpServletResponse resp) throws IOException {

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,8 @@ private void onUserTeams(HttpServletRequest req, HttpServletResponse resp) throw`
`249`	`249`
`250`	`250`	`private void onLoginOAuthAuthorize(HttpServletRequest req, HttpServletResponse resp) throws IOException {`
`251`	`251`	`String code = "test";`
`252`		`- resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code);`
	`252`	`+ String state = req.getParameter("state");`
	`253`	`+ resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code + "&state=" + state);`
`253`	`254`	`}`
`254`	`255`
`255`	`256`	`private void onLoginOAuthAccessToken(HttpServletRequest req, HttpServletResponse resp) throws IOException {`
Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ private void onUserTeams(HttpServletRequest req, HttpServletResponse resp) throw`
`246`	`246`	`private void onLoginOAuthAuthorize(HttpServletRequest req, HttpServletResponse resp) throws IOException {`
`247`	`247`	`String code = "test";`
`248`	`248`	`String state = req.getParameter("state");`
`249`		`- resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code+"&state="+state);`
	`249`	`+ resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code + "&state=" + state);`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`private void onLoginOAuthAccessToken(HttpServletRequest req, HttpServletResponse resp) throws IOException {`