Deletes duplicated method and issues reported by sonar (#179)

Author: damianszczepanik

src/test/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/actions/DeleteLogFileActionTest.java

@@ -27,7 +27,7 @@ void perform_OnExistingLogFile_DeletesLogFile() throws IOException, InterruptedE
         // then
         run.assertLogFileIsNotAvailable();
     }
-    
+
     @Test
     void perform_OnMissingLogFile_SkipDeletion() throws IOException, InterruptedException {
 
@@ -62,7 +62,7 @@ public File getLogFile() {
     }
 
     @Test
-    public void perform_DeleteLogFileDoesNotWork_IgnoresFailure() throws IOException, InterruptedException {
+    void perform_DeleteLogFileDoesNotWork_IgnoresFailure() throws IOException, InterruptedException {
 
         // given
         Action action = new DeleteLogFileAction();
@@ -82,5 +82,5 @@ public File getLogFile() {
         // then
         run.assertLogFileIsAvailable();
     }
-    
+
 }

src/test/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/conditions/BuildResultConditionTest.java

@@ -346,19 +346,4 @@ void match_OnNotMatchNotBuiltAndResultNotBuilt_ReturnsFalse() throws IOException
         // then
         assertThat(matched).isFalse();
     }
-
-    @Test
-    void match_OnMatchNotBuiltAndResultNotNotBuilt_ReturnsFalse() throws IOException {
-
-        // given
-        BuildResultCondition condition = new BuildResultCondition();
-        condition.setMatchNotBuilt(true);
-        Run<?, ?> run = new RunStub(Result.FAILURE);
-
-        // when
-        boolean matched = condition.matches(run, null);
-
-        // then
-        assertThat(matched).isFalse();
-    }
 }

src/test/java/pl/damianszczepanik/jenkins/buildhistorymanager/utils/RunStub.java

@@ -26,6 +26,7 @@ public class RunStub extends Run {
     public enum LogFileAvailability {
         PRESENT, ABSENT
     }
+
     private Result result;
     private LogFileAvailability logFileState = LogFileAvailability.PRESENT;
     private List<Cause> causes;
@@ -37,7 +38,7 @@ public RunStub(LogFileAvailability logFileState) throws IOException {
         this();
         this.logFileState = logFileState;
     }
-    
+
     public RunStub(int buildNumber) throws IOException {
         this();
         setBuildNumber(buildNumber);
@@ -66,11 +67,10 @@ public RunStub(String causeClass) throws IOException {
 
     public RunStub(String[] causeClass) throws IOException {
         this();
-        List<Cause> causes = new ArrayList<>();
+        causes = new ArrayList<>();
         for (String cause : causeClass) {
             causes.add(new MockCause(cause));
         }
-        this.causes = causes;
     }
 
     public RunStub() throws IOException {
@@ -120,9 +120,9 @@ public void checkPermission(Permission permission) {
     }
 
     private boolean deleteLogFile() {
-        boolean result = logFileState == LogFileAvailability.PRESENT;
+        boolean deleteResult = logFileState == LogFileAvailability.PRESENT;
         logFileState = LogFileAvailability.ABSENT;
-        return result;
+        return deleteResult;
     }
 
     public void assertBuildWasDeleted() {
@@ -141,10 +141,14 @@ public void assertArtifactsAreAvailable() {
         assertThat(deleteArtifactsTimes).isZero();
     }
 
-    public void assertLogFileIsNotAvailable() { assertThat(logFileState).isEqualTo(LogFileAvailability.ABSENT); }
-    
-    public void assertLogFileIsAvailable() { assertThat(logFileState).isEqualTo(LogFileAvailability.PRESENT); }
-    
+    public void assertLogFileIsNotAvailable() {
+        assertThat(logFileState).isEqualTo(LogFileAvailability.ABSENT);
+    }
+
+    public void assertLogFileIsAvailable() {
+        assertThat(logFileState).isEqualTo(LogFileAvailability.PRESENT);
+    }
+
 
     @Override
     public Result getResult() {