Refactor: minor code cleanup and corrections

Author: Nurgul Amat

src/main/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/conditions/Condition.java

@@ -15,6 +15,7 @@ public abstract class Condition extends AbstractDescribableImpl<Condition> {
 
     /**
      * Decides if the build matches given criteria to be updated or not.
+     *
      * @param run           build which should be evaluated
      * @param configuration configuration from the role
      * @param buildPosition the position of the build in the build history

src/main/resources/pl/damianszczepanik/jenkins/buildhistorymanager/model/conditions/BuildPositionCondition/help.html

@@ -1,8 +1,8 @@
 <p><b>Description</b></p>
-<p>Build position in build history ....</p>
+<p>TODO</p>
 
 <p><b>Use cases</b></p>
-<p>???</p>
+<p>TODO</p>
 
 <p><b>Warning!</b></p>
-<p>???</p>
+<p>TODO</p>

src/test/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/RuleTest.java

@@ -22,7 +22,7 @@
  */
 public class RuleTest {
 
-    public static int buildPosition = 0;
+    public static final int FIRST_BUILD_POSITION = 0;
 
     @Test
     public void getConditions_ReturnsConditions() {
@@ -103,7 +103,7 @@ public void validateConditions_MatchesAllConditions() {
         Run<?, ?> run = mock(Run.class);
 
         // when
-        rule.validateConditions(run, buildPosition);
+        rule.validateConditions(run, FIRST_BUILD_POSITION);
 
         // then
         for (Condition condition : rule.getConditions()) {
@@ -119,7 +119,7 @@ public void validateConditions_OnNegativeCondition_DoesNotIncrementMatchedTimes(
         Run<?, ?> run = mock(Run.class);
 
         // when
-        rule.validateConditions(run, buildPosition);
+        rule.validateConditions(run, FIRST_BUILD_POSITION);
 
         // then
         int matchedTimes = Deencapsulation.getField(rule, "matchedTimes");
@@ -151,8 +151,8 @@ public void validateConditions_PerformsNTimes() throws IOException, InterruptedE
         Run<?, ?> run = mock(Run.class);
 
         // when
-        rule.validateConditions(run, buildPosition);
-        rule.validateConditions(run, buildPosition);
+        rule.validateConditions(run, FIRST_BUILD_POSITION);
+        rule.validateConditions(run, FIRST_BUILD_POSITION);
 
         // then
         int matchedTimes = Deencapsulation.getField(rule, "matchedTimes");

src/test/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/conditions/MatchEveryBuildConditionTest.java

@@ -18,7 +18,7 @@ public void matches_ReturnsTrue() throws IOException, InterruptedException {
         MatchEveryBuildCondition condition = new MatchEveryBuildCondition();
 
         // when
-        boolean matches =condition.matches(null, null, 0);
+        boolean matches = condition.matches(null, null, 0);
 
         // then
         assertThat(matches).isTrue();