Skip to content

Commit c84807b

Browse files
committed
[JENKINS-74879] Use strikethrough on merged pull request name column
https://issues.jenkins.io/browse/JENKINS-74879 reports that the strikethrough text is no longer previously displayed when a pull request has been merged or closed. The strikethrough text is a nice visual indicator that the job is no longer active. Let's bring it back so that the visual hint is still there for users. The strikethrough text is displayed on the job page, but not in the table of jobs for each pull request or branch. Change was originally introduced when pull request titles were enabled by default in the column name. Refer to: * #476 Assumed that it is better to drop the jenkins-table__link formatting in the plugin rather than adjust the CSS definion in Jenkins core. That CSS definition has been in place in Jenkins core since Sep 2022 and likely would have unexpected side effects if changed in core. Refer to: * jenkinsci/jenkins#6248 Testing done: * Confirmed that the link has strikethrough text with this change. * Confirmed that the non-striketrhrough link still looks good
1 parent 313fb0c commit c84807b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/resources/jenkins/branch/ItemColumn/column.jelly

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ THE SOFTWARE.
2727
xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
2828
<d:taglib uri="local">
2929
<d:tag name="link">
30-
<a href="${jobBaseUrl}${job.shortUrl}" class='model-link jenkins-table__link'>
30+
<a href="${jobBaseUrl}${job.shortUrl}" class='model-link'>
3131
<span>
3232
<l:breakable value="${h.getRelativeDisplayNameFrom(job, itemGroup)}"/>
3333
</span>

0 commit comments

Comments
 (0)