Refatctor tests and add more cases to increase coverage

Author: bradsawadye

test/integration/metadataAPITests.js

@@ -108,6 +108,11 @@ const sampleMetadata = {
         {user: 'User 6', method: 'email', maxAlerts: '1 per day'}
       ]
     }
+  ],
+  Keystore: [
+    {
+      key: 'Key'
+    }
   ]
 }
 
@@ -748,9 +753,99 @@ describe('API Integration Tests', () => {
         await testUtils.setupTestUsers()
       })
 
-      it('should validate metadata and return status 201', async () => {
-        const im = await PassportModelAPI.find()
+      const sampleMetadata = {
+        Channels: [
+          {
+            name: 'TestChannel1',
+            urlPattern: 'test/sample',
+            allow: ['PoC', 'Test1', 'Test2'],
+            routes: [
+              {name: 'test route', host: 'localhost', port: 9876, primary: true}
+            ],
+            txViewAcl: 'group1',
+            updatedBy: {
+              id: new ObjectId(),
+              name: 'Test'
+            }
+          }
+        ],
+        Clients: [
+          {
+            clientID: 'YUIAIIIICIIAIA',
+            clientDomain: 'him.jembi.org',
+            name: 'OpenMRS Ishmael instance',
+            roles: ['OpenMRS_PoC', 'PoC'],
+            passwordHash:
+              '$2a$10$w8GyqInkl72LMIQNpMM/fenF6VsVukyya.c6fh/GRtrKq05C2.Zgy',
+            certFingerprint:
+              '23:37:6A:5E:A9:13:A4:8C:66:C5:BB:9F:0E:0D:68:9B:99:80:10:FC'
+          }
+        ],
+        Mediators: [
+          {
+            urn: 'urn:uuid:EEA84E13-1C92-467C-B0BD-7C480462D1ED',
+            version: '1.0.0',
+            name: 'Save Encounter Mediator',
+            description: 'A mediator for testing',
+            endpoints: [
+              {
+                name: 'Save Encounter',
+                host: 'localhost',
+                port: '8005',
+                type: 'http'
+              }
+            ],
+            defaultChannelConfig: [
+              {
+                name: 'Save Encounter 1',
+                urlPattern: '/encounters',
+                type: 'http',
+                allow: [],
+                routes: [
+                  {
+                    name: 'Save Encounter 1',
+                    host: 'localhost',
+                    port: '8005',
+                    type: 'http'
+                  }
+                ]
+              }
+            ]
+          }
+        ],
+        Users: [
+          {
+            firstname: 'Namey',
+            surname: 'mcTestName',
+            email: '[email protected]',
+            passwordAlgorithm: 'sha512',
+            passwordHash: '796a5a8e-4e44-4d9f-9e04-c27ec6374ffa',
+            passwordSalt: 'bf93caba-6eec-4c0c-a1a3-d968a7533fd7',
+            groups: ['admin', 'RHIE']
+          }
+        ],
+        Passports: [
+          {
+            email: '[email protected]',
+            protocol: 'local'
+          }
+        ],
+        ContactGroups: [
+          {
+            group: 'Group 1',
+            users: [
+              {user: 'User 1', method: 'sms', maxAlerts: 'no max'},
+              {user: 'User 2', method: 'email', maxAlerts: '1 per hour'},
+              {user: 'User 3', method: 'sms', maxAlerts: '1 per day'},
+              {user: 'User 4', method: 'email', maxAlerts: 'no max'},
+              {user: 'User 5', method: 'sms', maxAlerts: '1 per hour'},
+              {user: 'User 6', method: 'email', maxAlerts: '1 per day'}
+            ]
+          }
+        ]
+      }
 
+      it('should validate metadata and return status 201', async () => {
         const res = await request(BASE_URL)
           .post('/metadata/validate')
           .set('Cookie', rootCookie)

test/unit/metadataTest.js

@@ -58,6 +58,11 @@ describe('Metadata Functions', () => {
         groups: 'cgUID'
       })
       result.should.have.property('groups', 'cgUID')
+
+      result = metadata.getUniqueIdentifierForCollection('Invalid-collection', {
+        id: '123333'
+      })
+      result.should.deepEqual({})
       return done()
     }))