Skip to content

Missing "postIterations()" call in SCG training "iteration()" method. Bug? #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wiemp opened this issue Mar 12, 2014 · 2 comments
Closed
Labels
Milestone

Comments

@wiemp
Copy link

wiemp commented Mar 12, 2014

Hello,
I currently tested around with SCG training method and added a "EndIterationsStrategy" to the train method. I executed the training with EncogUtility.trainToError and expected to stop either at the reached error rate or after the specified number of iterations.
This was working, when I used the ResilientPropagation train method, but for SCG, it didn't stop. While checking the "iteration()" method in ScaledConjugateGradient, I didn't find a "postIterations()" method (like the Propagation "iterations()" method), to call this for the EndIterationsStrategy strategy, so I assume, it's missing. Am I right?
I'm using the 3.2.0 released version.

regards,
Winfried

@jeffheaton
Copy link
Owner

Yes that probably should be in there

@jeffheaton jeffheaton added the Bug label Sep 23, 2014
@jeffheaton jeffheaton modified the milestones: Encog 3.3, Encog v3.3 Sep 23, 2014
@jeffheaton
Copy link
Owner

I show it as like 361.

    ++this.k;

    EngineArray.arrayCopy(this.weights, this.network.getFlat().getWeights());

    postIteration();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants