feat: add method to check if no_proxy is empty

Signed-off-by: Jérémie Drouet <[email protected]>

Author: jdrouet

src/lib.rs

@@ -91,7 +91,9 @@ pub struct NoProxy {
 impl NoProxy {
     fn from_iterator<V: AsRef<str>, I: Iterator<Item = V>>(iterator: I) -> Self {
         let content: HashSet<_> = iterator
-            .map(|item| NoProxyItem::from(item.as_ref().trim().to_string()))
+            .map(|item| item.as_ref().trim().to_string())
+            .filter(|item| !item.is_empty())
+            .map(NoProxyItem::from)
             .collect();
         let has_wildcard = content.contains(&NoProxyItem::Wildcard);
         Self {
@@ -136,6 +138,10 @@ impl Extend<NoProxyItem> for NoProxy {
 }
 
 impl NoProxy {
+    pub fn is_empty(&self) -> bool {
+        self.content.is_empty()
+    }
+
     pub fn matches(&self, input: &str) -> bool {
         if self.has_wildcard {
             return true;
@@ -183,6 +189,12 @@ mod tests {
         );
     }
 
+    #[test]
+    fn filter_empty() {
+        let no_proxy = NoProxy::from("");
+        assert!(no_proxy.is_empty());
+    }
+
     #[test]
     fn wildcard() {
         should_match("*", "www.wikipedia.org");

src/serialize.rs

@@ -65,8 +65,10 @@ mod tests {
         // parsing a comma separated string
         let result: NoProxy = serde_json::from_str(&json).unwrap();
         assert_eq!(proxy, result);
+        assert_eq!(result.content.len(), 2);
         // parsing an array of strings
         let result: NoProxy = serde_json::from_str(r#"["foo.bar", "1.2.3.4"]"#).unwrap();
         assert_eq!(proxy, result);
+        assert_eq!(result.content.len(), 2);
     }
 }