Don't check constraint in explicit type argument scenario for now

Author: jcouv

src/Compilers/CSharp/Portable/Compilation/CSharpSemanticModel.cs

@@ -4690,11 +4690,7 @@ private static bool AddReducedAndFilteredSymbol(
                 {
                     constructedMethod = method.ConstructIncludingExtension(typeArguments);
                     Debug.Assert((object)constructedMethod != null);
-
-                    if (!checkConstraintsIncludingExtension(method, typeArguments, compilation, method.ContainingAssembly.CorLibrary.TypeConversions))
-                    {
-                        return false;
-                    }
+                    // PROTOTYPE we should check constraints
                 }
                 else
                 {
@@ -4746,46 +4742,6 @@ private static bool AddReducedAndFilteredSymbol(
             }
 
             throw ExceptionUtilities.UnexpectedValue(member.Kind);
-
-            static bool checkConstraintsIncludingExtension(MethodSymbol symbol, ImmutableArray<TypeWithAnnotations> typeArgs, CSharpCompilation compilation, TypeConversions conversions)
-            {
-                var diagnosticsBuilder = ArrayBuilder<TypeParameterDiagnosticInfo>.GetInstance();
-                ArrayBuilder<TypeParameterDiagnosticInfo>? useSiteDiagnosticsBuilder = null;
-
-                var constraintArgs = new ConstraintsHelper.CheckConstraintsArgs(compilation, conversions, includeNullability: false, NoLocation.Singleton, diagnostics: null, template: CompoundUseSiteInfo<AssemblySymbol>.Discarded);
-
-                bool success = true;
-
-                if (symbol.GetIsNewExtensionMember())
-                {
-                    NamedTypeSymbol extensionDeclaration = symbol.ContainingType;
-                    if (extensionDeclaration.Arity > 0)
-                    {
-                        var extensionTypeParameters = extensionDeclaration.TypeParameters;
-                        var extensionTypeArguments = typeArgs[..extensionDeclaration.Arity];
-                        var extensionSubstitution = new TypeMap(extensionTypeParameters, extensionTypeArguments);
-
-                        success = extensionDeclaration.CheckConstraints(
-                           constraintArgs, extensionSubstitution, extensionTypeParameters, extensionTypeArguments, diagnosticsBuilder,
-                           nullabilityDiagnosticsBuilderOpt: null, ref useSiteDiagnosticsBuilder, ignoreTypeConstraintsDependentOnTypeParametersOpt: null);
-                    }
-                }
-
-                if (success && symbol.Arity > 0)
-                {
-                    var memberTypeParameters = symbol.TypeParameters;
-                    var memberTypeArguments = typeArgs[^symbol.Arity..];
-                    var memberSubstitution = new TypeMap(memberTypeParameters, memberTypeArguments);
-
-                    success = symbol.CheckConstraints(
-                        constraintArgs, memberSubstitution, memberTypeParameters, memberTypeArguments, diagnosticsBuilder,
-                        nullabilityDiagnosticsBuilderOpt: null, ref useSiteDiagnosticsBuilder, ignoreTypeConstraintsDependentOnTypeParametersOpt: null);
-                }
-
-                diagnosticsBuilder.Free();
-
-                return success;
-            }
 #nullable disable
         }
 

src/Compilers/CSharp/Test/Emit3/Semantics/ExtensionTests.cs

@@ -11098,7 +11098,7 @@ static class E
         var invocation = GetSyntax<InvocationExpressionSyntax>(tree, "new C<int>().M<int, string>()");
         Assert.Null(model.GetSymbolInfo(invocation).Symbol);
         Assert.Equal([], model.GetMemberGroup(invocation).ToTestDisplayStrings());
-        Assert.Equal([], model.GetMemberGroup(invocation.Expression).ToTestDisplayStrings());
+        Assert.Equal(["void E.<>E__0<System.Int32>.M<System.String>()"], model.GetMemberGroup(invocation.Expression).ToTestDisplayStrings());
     }
 
     [Fact]
@@ -12851,7 +12851,7 @@ static class E1
         var model = comp.GetSemanticModel(tree);
         var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "new C().M<object>");
         Assert.Equal("void E2.<>E__0.M<System.Object>()", model.GetSymbolInfo(memberAccess).Symbol.ToTestDisplayString());
-        Assert.Equal(["void E2.<>E__0.M<System.Object>()"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+        Assert.Equal(["System.String Inner.E1.<>E__0.M<System.Object>()", "void E2.<>E__0.M<System.Object>()"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
     }
 
     [Fact]
@@ -24885,7 +24885,7 @@ static class E
         Assert.Equal([], model.GetMemberGroup(invocation).ToTestDisplayStrings());
 
         var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "42.M<object>");
-        Assert.Equal([], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+        Assert.Equal(["void E.<>E__0<System.Object>.M()"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
     }
 
     [Fact]
@@ -25079,13 +25079,11 @@ public static void M2<T>(this int i, T t) where T : struct { }
         var model = comp.GetSemanticModel(tree);
         var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "42.M<object>");
         Assert.Null(model.GetSymbolInfo(memberAccess).Symbol);
-        Assert.Equal([], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
-        Assert.Equal([], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+        Assert.Equal(["void E.<>E__0.M<System.Object>(System.Object t)"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
 
         memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "42.M2<object>");
         Assert.Null(model.GetSymbolInfo(memberAccess).Symbol);
-        Assert.Equal([], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
-        Assert.Equal([], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+        Assert.Equal(["void System.Int32.M2<System.Object>(System.Object t)"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
     }
 
     [Fact]
@@ -25446,10 +25444,10 @@ public static void M2<U>(this object o) where U : class { }
         var model = comp.GetSemanticModel(tree);
 
         var memberAccess1 = GetSyntax<MemberAccessExpressionSyntax>(tree, "object.M<int>");
-        Assert.Equal([], model.GetMemberGroup(memberAccess1).ToTestDisplayStrings());
+        Assert.Equal(["void E.<>E__0.M<System.Int32>()"], model.GetMemberGroup(memberAccess1).ToTestDisplayStrings());
 
         var memberAccess2 = GetSyntax<MemberAccessExpressionSyntax>(tree, "new object().M2<int>");
-        Assert.Equal([], model.GetMemberGroup(memberAccess2).ToTestDisplayStrings());
+        Assert.Equal(["void System.Object.M2<System.Int32>()"], model.GetMemberGroup(memberAccess2).ToTestDisplayStrings());
     }
 
     [Fact]
@@ -25518,10 +25516,10 @@ public static void M2<T>(this T t) where T : class { }
         var model = comp.GetSemanticModel(tree);
 
         var memberAccess1 = GetSyntax<MemberAccessExpressionSyntax>(tree, "int.M<int>");
-        Assert.Equal([], model.GetMemberGroup(memberAccess1).ToTestDisplayStrings());
+        Assert.Equal(["void E.<>E__0<System.Int32>.M()"], model.GetMemberGroup(memberAccess1).ToTestDisplayStrings());
 
         var memberAccess2 = GetSyntax<MemberAccessExpressionSyntax>(tree, "42.M2<int>");
-        Assert.Equal([], model.GetMemberGroup(memberAccess2).ToTestDisplayStrings());
+        Assert.Equal(["void System.Int32.M2<System.Int32>()"], model.GetMemberGroup(memberAccess2).ToTestDisplayStrings());
     }
 
     [Fact]

src/Compilers/CSharp/Test/Semantic/Semantics/DelegateTypeTests.cs

@@ -3018,7 +3018,7 @@ public void M<T>(object o) where T : class { }
             var model = comp.GetSemanticModel(tree);
             var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "new C().M<int>");
             Assert.Equal("void C.M<System.Int32>()", model.GetSymbolInfo(memberAccess).Symbol.ToTestDisplayString());
-            AssertEx.Equal(["void C.M<System.Int32>()"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+            AssertEx.Equal(["void C.M<System.Int32>()", "void C.M<System.Int32>(System.Object o)"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
         }
 
         [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/69222")]
@@ -3142,7 +3142,7 @@ public static void M<T>(this T t, object ignored) where T : struct { }
             var model = comp.GetSemanticModel(tree);
             var memberAccess = GetSyntax<MemberAccessExpressionSyntax>(tree, "new object().M<object>");
             Assert.Equal("void System.Object.M<System.Object>()", model.GetSymbolInfo(memberAccess).Symbol.ToTestDisplayString());
-            AssertEx.Equal(["void System.Object.M<System.Object>()"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
+            AssertEx.Equal(["void System.Object.M<System.Object>()", "void System.Object.M<System.Object>(System.Object ignored)"], model.GetMemberGroup(memberAccess).ToTestDisplayStrings());
         }
 
         [Theory, CombinatorialData]