Skip to content

Commit 0ba7657

Browse files
committed
much faster table drawing
1 parent b322377 commit 0ba7657

File tree

5 files changed

+82
-72
lines changed

5 files changed

+82
-72
lines changed

jmc/Backend/Audio/AudioModule.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -609,10 +609,11 @@ class AudioModule: NSObject {
609609
//called when a buffer is decoded. always schedule the buffer after the end of the current one
610610
//print("beginning of file buffer decode callback")
611611
let newBuffer = self.currentFileBufferer!.currentDecodeBuffer
612-
let currentBuffer = self.currentFileBufferer!.currentDecodeBuffer == self.currentFileBufferer!.bufferA ? self.currentFileBufferer!.bufferB : self.currentFileBufferer!.bufferA
613-
let frameToScheduleAt = nextBufferStartFrame
612+
//turns out all this math is unnecessary; scheduling 'at the end of all other buffers' is sufficient
613+
//let currentBuffer = self.currentFileBufferer!.currentDecodeBuffer == self.currentFileBufferer!.bufferA ? self.currentFileBufferer!.bufferB : self.currentFileBufferer!.bufferA
614+
//let frameToScheduleAt = nextBufferStartFrame
614615
//print("scheduling buffer \(newBuffer) at frame \(frameToScheduleAt). buffer is \(newBuffer.frameLength) in length")
615-
let time = AVAudioTime(sampleTime: frameToScheduleAt, atRate: currentBuffer.format.sampleRate)
616+
//let time = AVAudioTime(sampleTime: frameToScheduleAt, atRate: currentBuffer.format.sampleRate)
616617
//print(time)
617618
curPlayerNode.scheduleBuffer(newBuffer, at: nil, options: .init(rawValue: 0), completionHandler: fileBuffererCompletion)
618619
if isFinalBuffer == true {

jmc/Main Interface Components/Main Table View/LibraryTableViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -509,6 +509,7 @@ class LibraryTableViewController: NSViewController, NSMenuDelegate {
509509
tableView.target = self
510510
tableView.menu?.delegate = self
511511
tableView.doubleAction = #selector(tableViewDoubleClick)
512+
//tableView.enclosingScrollView?.wantsLayer = true
512513
columnVisibilityMenu.delegate = self
513514
//self.initializeColumnVisibilityMenu(self.tableView)
514515
tableView.delegate = trackViewArrayController

0 commit comments

Comments
 (0)