Skip to content

listener errors are thrown away and never checked. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whyrusleeping opened this issue Apr 12, 2015 · 1 comment
Closed

listener errors are thrown away and never checked. #4

whyrusleeping opened this issue Apr 12, 2015 · 1 comment

Comments

@whyrusleeping
Copy link
Collaborator

When an error causes a listener to error out and halt the listener, it is sent on the acceptErr channel, and then never checked. If something is causing our listeners to fail, we would never know.
@whyrusleeping whyrusleeping mentioned this issue Apr 12, 2015
Closed
@whyrusleeping
Copy link
Collaborator Author

Ah, nevermind. I missed the AcceptErrors, its just being logged as a Debugf in ipfs. Needs to be an Errorf these things are important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whyrusleeping