Skip to content

Commit a10fcfa

Browse files
committed
use NotImplementedError instead of returning none first_name/last_name
1 parent 4d3a848 commit a10fcfa

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

payments/models.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,29 +147,32 @@ def get_user(self):
147147
def get_user_email(self):
148148
""" Get user email """
149149
try:
150+
# Most common implementation
150151
return self.get_user().email
151152
except AttributeError:
152-
return None
153+
raise NotImplementedError()
153154

154155
def get_user_first_name(self):
155156
"""
156-
Get user first name
157+
Get user first name for purposes of the payment provider
157158
Used only by PayU provider for now
158159
"""
159160
try:
161+
# Most common implementation
160162
return self.get_user().first_name
161163
except AttributeError:
162-
return None
164+
raise NotImplementedError()
163165

164166
def get_user_last_name(self):
165167
"""
166-
Get user last name
168+
Get user last name for purposes of the payment provider
167169
Used only by PayU provider for now
168170
"""
169171
try:
172+
# Most common implementation
170173
return self.get_user().last_name
171174
except AttributeError:
172-
return None
175+
raise NotImplementedError()
173176

174177
def get_renew_token(self):
175178
"""

0 commit comments

Comments
 (0)