Skip to content

Commit 2ef577a

Browse files
committed
use NotImplementedError instead of returning none first_name/last_name
1 parent 942ea23 commit 2ef577a

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

payments/models.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,29 +149,32 @@ def get_user(self):
149149
def get_user_email(self):
150150
""" Get user email """
151151
try:
152+
# Most common implementation
152153
return self.get_user().email
153154
except AttributeError:
154-
return None
155+
raise NotImplementedError()
155156

156157
def get_user_first_name(self):
157158
"""
158-
Get user first name
159+
Get user first name for purposes of the payment provider
159160
Used only by PayU provider for now
160161
"""
161162
try:
163+
# Most common implementation
162164
return self.get_user().first_name
163165
except AttributeError:
164-
return None
166+
raise NotImplementedError()
165167

166168
def get_user_last_name(self):
167169
"""
168-
Get user last name
170+
Get user last name for purposes of the payment provider
169171
Used only by PayU provider for now
170172
"""
171173
try:
174+
# Most common implementation
172175
return self.get_user().last_name
173176
except AttributeError:
174-
return None
177+
raise NotImplementedError()
175178

176179
def get_renew_token(self):
177180
"""

0 commit comments

Comments
 (0)