Skip to content

Commit 15ac40b

Browse files
committed
Fix pyright issues
1 parent 79d929b commit 15ac40b

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

dj_database_url/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,21 +91,21 @@ def inner(func: PostprocessCallable) -> PostprocessCallable:
9191
@register("sqlite", "django.db.backends.sqlite3")
9292
def default_to_in_memory_db(parsed_config: DBConfig) -> None:
9393
# mimic sqlalchemy behaviour
94-
if parsed_config["NAME"] == "":
94+
if not parsed_config.get("NAME"):
9595
parsed_config["NAME"] = ":memory:"
9696

9797

9898
@register("oracle", "django.db.backends.oracle")
9999
@register("mssqlms", "mssql")
100100
@register("mssql", "sql_server.pyodbc")
101101
def stringify_port(parsed_config: DBConfig) -> None:
102-
parsed_config["PORT"] = str(parsed_config["PORT"])
102+
parsed_config["PORT"] = str(parsed_config.get("PORT", ""))
103103

104104

105105
@register("mysql", "django.db.backends.mysql")
106106
@register("mysql2", "django.db.backends.mysql")
107107
def apply_ssl_ca(parsed_config: DBConfig) -> None:
108-
options = parsed_config["OPTIONS"]
108+
options = parsed_config.get("OPTIONS", {})
109109
ca = options.pop("ssl-ca", None)
110110
if ca:
111111
options["ssl"] = {"ca": ca}
@@ -119,7 +119,7 @@ def apply_ssl_ca(parsed_config: DBConfig) -> None:
119119
@register("timescale", "timescale.db.backends.postgresql")
120120
@register("timescalegis", "timescale.db.backends.postgis")
121121
def apply_current_schema(parsed_config: DBConfig) -> None:
122-
options = parsed_config["OPTIONS"]
122+
options = parsed_config.get("OPTIONS", {})
123123
schema = options.pop("currentSchema", None)
124124
if schema:
125125
options["options"] = f"-c search_path={schema}"
@@ -237,7 +237,7 @@ def _convert_to_settings(
237237
conn_health_checks: bool,
238238
disable_server_side_cursors: bool,
239239
ssl_require: bool,
240-
test_options: Optional[dict],
240+
test_options: Optional[dict[str, Any]],
241241
) -> DBConfig:
242242
settings: DBConfig = {
243243
"CONN_MAX_AGE": conn_max_age,

tests/test_dj_database_url.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -669,10 +669,6 @@ def test_register_multiple_times__no_duplicates_in_uses_netloc(self):
669669
dj_database_url.register("django.contrib.db.backends.bag_end", "bag-end")
670670
assert len(uses_netloc) == len(set(uses_netloc))
671671

672-
def test_bad_url_parsing(self) -> None:
673-
with self.assertRaisesRegex(ValueError, "No support for 'foo'. We support: "):
674-
dj_database_url.parse("foo://bar")
675-
676672
@mock.patch.dict(
677673
os.environ,
678674
{"DATABASE_URL": "postgres://user:[email protected]:5431/d8r8?"},

0 commit comments

Comments
 (0)