Skip to content

Literate mode: incorrect column in locationData / source maps. #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marchaefner opened this issue Mar 14, 2013 · 1 comment
Closed

Literate mode: incorrect column in locationData / source maps. #2835

marchaefner opened this issue Mar 14, 2013 · 1 comment
Labels
bug fixed

Comments

@marchaefner
Copy link
Collaborator

Due to the (premature) removal of whitespace, the locationData of tokens and AST nodes will not point to the correct column. (Resulting in erroneous source maps and error reporting.)
marchaefner pushed a commit to marchaefner/coffee-script that referenced this issue Mar 14, 2013
Improve literate mode.
52ca531 
* Expect a blank line as delimiter between text and code (jashkenas#2821).
* Don't change indentation of code. It is not necessary and leads to
  erroneous locationData. (jashkenas#2835)
* Don't modify blank lines and reverse the change in the lexer.
* Don't ignore indentation with mixed whitespace.
@marchaefner marchaefner mentioned this issue Mar 14, 2013
Merged
@jashkenas
Copy link
Owner

Should be fixed now.

hden pushed a commit to hden/coffee-script that referenced this issue Mar 18, 2013
@hden
Improve literate mode.
af24601 
* Expect a blank line as delimiter between text and code (jashkenas#2821).
* Don't change indentation of code. It is not necessary and leads to
  erroneous locationData. (jashkenas#2835)
* Don't modify blank lines and reverse the change in the lexer.
* Don't ignore indentation with mixed whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jashkenas @marchaefner