Skip to content

Commit 9b057cc

Browse files
authored
mono - updating xo, @types/node, and webpack modules to latest (#795)
* mono - updating xo, @types/node, and webpack modules to latest * upgrading xo on dependent packages * updating xo on keyv package * updating mongo to support xo changes * updating xo in offline package * updating redis with new xo
1 parent c7e5a6b commit 9b057cc

File tree

11 files changed

+20
-20
lines changed

11 files changed

+20
-20
lines changed

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818
"clean": "rm -rf node_modules && rm -rf yarn.lock && yarn workspaces run clean"
1919
},
2020
"dependencies": {
21-
"@types/node": "^18.15.11"
21+
"@types/node": "^20.1.0",
22+
"webpack": "^5.82.0"
2223
},
2324
"devDependencies": {
2425
"ava": "^5.2.0",
2526
"c8": "^7.13.0",
26-
"xo": "^0.54.1"
27+
"xo": "^0.54.2"
2728
}
2829
}

packages/compress-brotli/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"xo": {
1515
"rules": {
1616
"unicorn/prefer-module": 0,
17+
"@typescript-eslint/no-unsafe-argument": 0,
1718
"@typescript-eslint/no-unsafe-call": 0,
1819
"@typescript-eslint/consistent-type-definitions": 0,
1920
"ava/no-ignored-test-files": [
@@ -64,7 +65,7 @@
6465
"tsd": "^0.28.1",
6566
"typescript": "^5.0.3",
6667
"webpack": "^5.77.0",
67-
"xo": "^0.53.1"
68+
"xo": "^0.54.2"
6869
},
6970
"tsd": {
7071
"directory": "test"

packages/compress-gzip/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
"ts-node": "^10.9.1",
7575
"tsd": "^0.28.1",
7676
"typescript": "^5.0.3",
77-
"xo": "^0.53.1"
77+
"xo": "^0.54.2"
7878
},
7979
"tsd": {
8080
"directory": "test"

packages/etcd/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"tsd": "^0.28.1",
6969
"typescript": "^5.0.4",
7070
"webpack": "^5.79.0",
71-
"xo": "^0.54.1"
71+
"xo": "^0.54.2"
7272
},
7373
"tsd": {
7474
"directory": "test"

packages/keyv/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"rules": {
1515
"unicorn/prefer-module": 0,
1616
"unicorn/prefer-node-protocol": 0,
17+
"unicorn/no-typeof-undefined": 0,
1718
"@typescript-eslint/consistent-type-definitions": 0
1819
}
1920
},
@@ -47,7 +48,7 @@
4748
"timekeeper": "^2.2.0",
4849
"tsd": "^0.28.1",
4950
"typescript": "^5.0.3",
50-
"xo": "^0.53.1"
51+
"xo": "^0.54.2"
5152
},
5253
"tsd": {
5354
"directory": "test"

packages/mongo/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"unicorn/no-array-reduce": 0,
1717
"unicorn/prefer-object-from-entries": 0,
1818
"unicorn/prefer-node-protocol": 0,
19+
"@typescript-eslint/consistent-type-imports": 0,
1920
"ava/no-ignored-test-files": [
2021
"error",
2122
{
@@ -74,7 +75,7 @@
7475
"ts-node": "^10.8.2",
7576
"tsd": "^0.20.0",
7677
"typescript": "^4.6.4",
77-
"xo": "^0.48.0"
78+
"xo": "^0.54.2"
7879
},
7980
"tsd": {
8081
"directory": "test"

packages/mongo/src/index.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {EventEmitter} from 'events';
2-
import GridFSBucket from 'mongodb';
3-
import {Store, StoredData} from 'keyv';
2+
import type GridFSBucket from 'mongodb';
3+
import {type Store, type StoredData} from 'keyv';
44

55
declare class KeyvMongo<Value=any> extends EventEmitter implements Store<Value> {
66
readonly ttlSupport: false;
@@ -27,7 +27,7 @@ declare class KeyvMongo<Value=any> extends EventEmitter implements Store<Value>
2727
export = KeyvMongo;
2828

2929
declare namespace KeyvMongo {
30-
interface Options {
30+
type Options = {
3131
url?: string | undefined;
3232
collection?: string | undefined;
3333
namespace?: string | undefined;
@@ -36,5 +36,5 @@ declare namespace KeyvMongo {
3636
useGridFS?: boolean | undefined;
3737
uri?: string | undefined;
3838
dialect?: string | undefined;
39-
}
39+
};
4040
}

packages/mongo/src/index.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class KeyvMongo extends EventEmitter {
131131
stream.on('error', () => resolve());
132132

133133
stream.on('end', () => {
134-
resp = Buffer.concat(resp).toString('utf-8');
134+
resp = Buffer.concat(resp).toString('utf8');
135135
resolve(resp);
136136
});
137137

@@ -181,11 +181,7 @@ class KeyvMongo extends EventEmitter {
181181
for (const key of keys) {
182182
const rowIndex = values.findIndex(row => row.key === key);
183183

184-
if (rowIndex > -1) {
185-
results[i] = values[rowIndex].value;
186-
} else {
187-
results[i] = undefined;
188-
}
184+
results[i] = rowIndex > -1 ? values[rowIndex].value : undefined;
189185

190186
i++;
191187
}

packages/offline/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
"ts-node": "^10.9.1",
7474
"tsd": "^0.28.1",
7575
"typescript": "^5.0.3",
76-
"xo": "^0.53.1"
76+
"xo": "^0.54.2"
7777
},
7878
"tsd": {
7979
"directory": "test"

packages/redis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"ts-node": "^10.9.1",
7171
"tsd": "^0.28.1",
7272
"typescript": "^5.0.3",
73-
"xo": "^0.53.1"
73+
"xo": "^0.54.2"
7474
},
7575
"tsd": {
7676
"directory": "test"

packages/redis/src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class KeyvRedis extends EventEmitter {
3939
}
4040

4141
set(key, value, ttl) {
42-
if (typeof value === 'undefined') {
42+
if (value === undefined) {
4343
return Promise.resolve(undefined);
4444
}
4545

0 commit comments

Comments
 (0)