Skip to content

Commit 08e89cf

Browse files
authored
etcd - chore: upgrading xo to 1.1.0 (#1459)
1 parent 9dfc16a commit 08e89cf

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

packages/etcd/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"rimraf": "^6.0.1",
5050
"typescript": "^5.8.3",
5151
"vitest": "^3.1.3",
52-
"xo": "^0.60.0"
52+
"xo": "^1.1.0"
5353
},
5454
"peerDependencies": {
5555
"keyv": "workspace:^"

packages/etcd/src/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
5454
});
5555

5656
// Https://github.com/microsoft/etcd3/issues/105
57-
// eslint-disable-next-line @typescript-eslint/use-unknown-in-catch-callback-variable
57+
// eslint-disable-next-line @typescript-eslint/use-unknown-in-catch-callback-variable, promise/prefer-await-to-then
5858
this.client.getRoles().catch(error => this.emit('error', error));
5959

6060
if (this.ttlSupport) {
@@ -75,6 +75,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
7575
}
7676

7777
return Promise.allSettled(promises)
78+
// eslint-disable-next-line promise/prefer-await-to-then
7879
.then(values => {
7980
const data: Array<StoredData<Value>> = [];
8081
for (const value of values) {
@@ -107,6 +108,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
107108
return false;
108109
}
109110

111+
// eslint-disable-next-line promise/prefer-await-to-then
110112
return this.client.delete().key(key).then(key => key.deleted !== '0');
111113
}
112114

@@ -117,13 +119,15 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
117119
}
118120

119121
// @ts-expect-error - x is an object
122+
// eslint-disable-next-line promise/prefer-await-to-then
120123
return Promise.allSettled(promises).then(values => values.every(x => x.value === true));
121124
}
122125

123126
async clear(): ClearOutput {
124127
const promise = this.namespace
125128
? this.client.delete().prefix(this.namespace)
126129
: this.client.delete().all();
130+
// eslint-disable-next-line promise/prefer-await-to-then
127131
return promise.then(() => undefined);
128132
}
129133

@@ -133,6 +137,7 @@ export class KeyvEtcd<Value = any> extends EventEmitter {
133137
.prefix(namespace ? namespace + ':' : '')
134138
.keys();
135139

140+
// eslint-disable-next-line @typescript-eslint/await-thenable
136141
for await (const key of iterator) {
137142
const value = await this.get(key);
138143
yield [key, value];

packages/etcd/vitest.config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ export default defineConfig({
66
coverage: {
77
reporter: ['json', 'lcov', 'text'],
88
reportOnFailure: true,
9+
exclude: [
10+
'src/types.ts',
11+
'vitest.config.ts',
12+
'dist',
13+
],
914
},
1015
},
1116
});

0 commit comments

Comments
 (0)