fix(notifications): return a detailed message for validation errors (#1315)

ydayagi · web-flow · commit e1c70463b4d5 · 2024-03-11T09:40:42.000Z
return a detailed message for validation errors FLPATH-1091 https://issues.redhat.com/browse/FLPATH-1091 Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
diff --git a/plugins/notifications-backend/src/service/router.ts b/plugins/notifications-backend/src/service/router.ts
@@ -142,7 +142,8 @@ export async function createRouter(
     }
     const validation = api.validateRequest(req as Request);
     if (!validation.valid) {
-      throw validation.errors;
+      res.status(500).json({ status: 500, err: validation.errors });
+      return;
     }
 
     api.handleRequest(req as Request, req, res).catch(next);

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,8 @@ export async function createRouter(`
`142`	`142`	`}`
`143`	`143`	`const validation = api.validateRequest(req as Request);`
`144`	`144`	`if (!validation.valid) {`
`145`		`- throw validation.errors;`
	`145`	`+ res.status(500).json({ status: 500, err: validation.errors });`
	`146`	`+ return;`
`146`	`147`	`}`
`147`	`148`
`148`	`149`	`api.handleRequest(req as Request, req, res).catch(next);`