fix(rbac): clean up

Signed-off-by: Oleksandr Andriienko <[email protected]>

Author: AndrienkoAleksandr

plugins/rbac-backend/src/service/policies-rest-api.test.ts

@@ -319,7 +319,7 @@ describe('REST policies api', () => {
     jest.clearAllMocks();
   });
 
-  it('should build', async () => {
+  it('should build', () => {
     expect(app).toBeTruthy();
   });
 
@@ -558,7 +558,6 @@ describe('REST policies api', () => {
       mockedAuthorizeConditional.mockImplementationOnce(async () => [
         { result: AuthorizeResult.DENY },
       ]);
-
       const result = await request(app)
         .get('/policies/user/default/permission_admin')
         .send();
@@ -1192,7 +1191,6 @@ describe('REST policies api', () => {
         .mockImplementation(async (..._param: string[]): Promise<boolean> => {
           return true;
         });
-
       const result = await request(app)
         .put('/policies/user/default/permission_admin')
         .send({
@@ -2479,30 +2477,29 @@ describe('REST policies api', () => {
   });
 
   describe('GetFirstQuery', () => {
-    it('should return an empty string for undefined query value', async () => {
+    it('should return an empty string for undefined query value', () => {
       const result = server.getFirstQuery(undefined);
       expect(result).toBe('');
     });
 
     it('should return the first string value from a string array', async () => {
       const queryValue = ['value1', 'value2'];
-
       const result = server.getFirstQuery(queryValue);
       expect(result).toBe('value1');
     });
 
-    it('should throw an InputError for an array of ParsedQs', async () => {
+    it('should throw an InputError for an array of ParsedQs', () => {
       const queryValue = [{ key: 'value' }, { key: 'value2' }];
       expect(() => server.getFirstQuery(queryValue)).toThrow(InputError);
     });
 
-    it('should return the string value when query value is a string', async () => {
+    it('should return the string value when query value is a string', () => {
       const queryValue = 'singleValue';
       const result = server.getFirstQuery(queryValue);
       expect(result).toBe('singleValue');
     });
 
-    it('should throw an InputError for ParsedQs', async () => {
+    it('should throw an InputError for ParsedQs', () => {
       const queryValue = { key: 'value' };
       expect(() => server.getFirstQuery(queryValue)).toThrow(InputError);
     });
@@ -2580,7 +2577,6 @@ describe('REST policies api', () => {
             return [];
           },
         );
-
       const result = await request(app)
         .get('/roles/conditions?pluginId=catalog')
         .send();
@@ -2603,7 +2599,6 @@ describe('REST policies api', () => {
             return [];
           },
         );
-
       const result = await request(app)
         .get('/roles/conditions?pluginId=scaffolder')
         .send();
@@ -2626,7 +2621,6 @@ describe('REST policies api', () => {
             return [];
           },
         );
-
       const result = await request(app)
         .get('/roles/conditions?resourceType=catalog-entity')
         .send();
@@ -2803,7 +2797,6 @@ describe('REST policies api', () => {
           params: { claims: ['group:default/team-a'] },
         },
       };
-
       const result = await request(app)
         .post('/roles/conditions')
         .send(roleCondition);
@@ -2865,7 +2858,6 @@ describe('REST policies api', () => {
             params: { claims: ['group:default/team-a'] },
           },
         };
-
       const result = await request(app)
         .put('/roles/conditions/1')
         .send(conditionDecision);
@@ -2917,7 +2909,6 @@ describe('REST policies api', () => {
         .mockImplementation(async () => {
           return pluginMetadata;
         });
-
       const result = await request(app).get('/plugins/policies').send();
       expect(result.statusCode).toEqual(200);
       expect(result.body).toEqual(pluginMetadata);
@@ -2927,7 +2918,6 @@ describe('REST policies api', () => {
       mockedAuthorizeConditional.mockImplementationOnce(async () => [
         { result: AuthorizeResult.DENY },
       ]);
-
       const result = await request(app).get('/plugins/policies').send();
 
       expect(mockedAuthorizeConditional).toHaveBeenCalledWith(
@@ -2971,7 +2961,6 @@ describe('REST policies api', () => {
         .mockImplementation(async () => {
           return rules;
         });
-
       const result = await request(app).get('/plugins/condition-rules').send();
       expect(result.statusCode).toEqual(200);
       expect(result.body).toEqual(rules);
@@ -2981,7 +2970,6 @@ describe('REST policies api', () => {
       mockedAuthorizeConditional.mockImplementationOnce(async () => [
         { result: AuthorizeResult.DENY },
       ]);
-
       const result = await request(app).get('/plugins/condition-rules').send();
 
       expect(mockedAuthorizeConditional).toHaveBeenCalledWith(