Fix tsc

Author: Alberto Gutierrez

plugins/kiali-backend/src/clients/fetch.test.ts

@@ -139,7 +139,7 @@ describe('kiali Fetch', () => {
       );
 
       jest.mock('./fetch', () => ({
-        getAuthInfo: jest.fn(() => Promise.reject({})),
+        getAuthInfo: Promise.reject({}),
       }));
       const validations = await kialiFetch.checkSession();
       expect(validations).toBeDefined();

plugins/kiali-backend/src/clients/fetch.ts

@@ -106,12 +106,12 @@ export class KialiFetcher {
        * Check Configuration
        */
       checkValidations = this.validateConfiguration(auth);
-    } catch (error) {
+    } catch (error: any) {
       return {
         verify: false,
         category: ValidationCategory.networking,
         title: 'Error reaching Kiali',
-        message: error.message,
+        message: error.message || '',
         helper: `Check if ${this.KialiDetails.url} works`,
       };
     }

plugins/kiali/dev/index.tsx

@@ -12,7 +12,7 @@ import { createDevApp } from '@backstage/dev-utils';
 import { EntityProvider } from '@backstage/plugin-catalog-react';
 import { TestApiProvider } from '@backstage/test-utils';
 
-import { Card, CardMedia, Grid } from '@material-ui/core';
+import { Grid } from '@material-ui/core';
 
 import { kialiPlugin } from '../src';
 import { getEntityRoutes, getRoutes } from '../src/components/Router';

plugins/kiali/src/components/BreadcrumbView/BreadcrumbView.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { Link, Location, useLocation } from 'react-router-dom';
+import { Location, useLocation } from 'react-router-dom';
 
 import { Breadcrumbs } from '@material-ui/core';
 

plugins/kiali/src/components/VirtualList/Renderers.tsx

@@ -94,8 +94,8 @@ export const item: Renderer<TResource> = (
         cluster={resource.cluster}
         objectType={
           config.name === 'istio'
-            ? IstioTypes[resource.type].url
-            : resource.type || undefined
+            ? IstioTypes[(resource as IstioConfigItem).type].url
+            : (resource as WorkloadListItem).type || undefined
         }
         key={key}
         className={linkColor}

plugins/kiali/src/utils/janusLinks.tsx

@@ -1,7 +1,11 @@
 import * as React from 'react';
 import { Link as RouterLink } from 'react-router-dom';
 
-import { SubRouteRef, useRouteRef } from '@backstage/core-plugin-api';
+import {
+  RouteFunc,
+  SubRouteRef,
+  useRouteRef,
+} from '@backstage/core-plugin-api';
 
 import { Link } from '@material-ui/core';
 
@@ -18,6 +22,7 @@ import {
   workloadsRouteRef,
 } from '../routes';
 
+type routeRefParams = undefined | { [key: string]: string };
 export const janusRoutesObject: {
   [key: string]: { id: string; ref: SubRouteRef };
 } = {
@@ -49,7 +54,7 @@ interface JanusLinkProps {
   className?: string;
   entity?: boolean;
   name?: string;
-  type?: string;
+  type: string;
   namespace?: string;
   objectType?: string;
   query?: string;
@@ -58,12 +63,12 @@ interface JanusLinkProps {
 }
 
 export const JanusObjectLink = (props: JanusLinkProps) => {
-  const { name, type, objectType, namespace, cluster, query } = props;
-  const link = useRouteRef(
+  const { name, type, objectType, namespace, query, cluster } = props;
+  const link: RouteFunc<routeRefParams> = useRouteRef(
     props.entity ? rootRouteRef : janusRoutesObject[type].ref,
   );
   const items: { [key: string]: string } = { namespace: namespace || '' };
-  if (type) {
+  if (type && name) {
     items[janusRoutesObject[type].id] = name;
   }
   if (objectType) {
@@ -74,7 +79,9 @@ export const JanusObjectLink = (props: JanusLinkProps) => {
     <Link
       component={RouterLink}
       to={href}
-      data-test={`${janusRoutesObject[type].id || ''}-${namespace}-${name}`}
+      data-test={`${
+        type ? janusRoutesObject[type].id : ''
+      }-${namespace}-${name}`}
       {...props}
     >
       {props.children || `${namespace}/${name}`}

yarn.lock

@@ -36995,4 +36995,4 @@ zod@^3.22.4:
 zwitch@^2.0.0:
   version "2.0.4"
   resolved "https://registry.yarnpkg.com/zwitch/-/zwitch-2.0.4.tgz#c827d4b0acb76fc3e685a4c6ec2902d51070e9d7"
-  integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==
+  integrity sha512-bXE4cR/kVZhKZX/RjPEflHaKVhUVl85noU3v6b8apfQEc1x4A+zBxjZ4lN8LqGd6WZ3dl98pY4o717VFmoPp+A==