Skip to content

Commit 4ffa93a

Browse files
osdnkjanicduplessis
authored andcommitted
Restore dropping handler or unmounting (software-mansion#604)
software-mansion/pull/406/files#diff-88fa64c878efe14d137f130ddbe000a5R185 From unknown reason, it has been changed here. Probably it's just a mistake, but it was leading to memory leaks.
1 parent 66239b3 commit 4ffa93a

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

createHandler.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,8 @@ export default function createHandler(
184184
RNGestureHandlerModule.updateGestureHandler(this._handlerTag, newConfig);
185185
};
186186

187-
_dropGestureHandler = () => {
188-
RNGestureHandlerModule.dropGestureHandler(this._handlerTag);
189-
};
190-
191187
componentWillUnmount() {
188+
RNGestureHandlerModule.dropGestureHandler(this._handlerTag);
192189
if (this._updateEnqueued) {
193190
clearImmediate(this._updateEnqueued);
194191
}

0 commit comments

Comments
 (0)