Skip to content

Commit 087d347

Browse files
authored
Merge pull request #180 from tagliala/chore/configure-described-class-cop
Set `RSpec/DescribedClass` cop to `explicit`
2 parents daee59f + c2519ab commit 087d347

File tree

5 files changed

+14
-24
lines changed

5 files changed

+14
-24
lines changed

.rubocop.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,7 @@ AllCops:
1515
# https://github.com/jamesmartin/inline_svg/pull/171/files#r1798763446
1616
Style/EachWithObject:
1717
Enabled: false
18+
19+
# https://github.com/jamesmartin/inline_svg/pull/177#issuecomment-2530239552
20+
RSpec/DescribedClass:
21+
EnforcedStyle: explicit

.rubocop_todo.yml

Lines changed: 2 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gemfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ gem "pry"
1010
gem "rake"
1111
gem "rspec"
1212

13-
gem "rubocop", "1.66.1"
14-
gem "rubocop-packaging", "0.5.2"
15-
gem "rubocop-performance", "1.22.1"
16-
gem "rubocop-rake", "0.6.0"
17-
gem "rubocop-rspec", "3.0.5"
13+
gem "rubocop", "1.69.2", require: false
14+
gem "rubocop-packaging", "0.5.2", require: false
15+
gem "rubocop-performance", "1.23.0", require: false
16+
gem "rubocop-rake", "0.6.0", require: false
17+
gem "rubocop-rspec", "3.3.0", require: false

spec/static_asset_finder_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
stub_const('Rails', double('Rails').as_null_object)
99
expect(Rails.application.config.assets).to receive(:compile).and_return(true)
1010

11-
expect(described_class.find_asset('some-file').pathname).to be_nil
11+
expect(InlineSvg::StaticAssetFinder.find_asset('some-file').pathname).to be_nil
1212
end
1313
end
1414

@@ -21,7 +21,7 @@
2121
expect(asset).to receive(:filename).and_return(pathname)
2222
expect(Rails.application.assets).to receive(:[]).with('some-file').and_return(asset)
2323

24-
expect(described_class.find_asset('some-file').pathname).to eq(pathname)
24+
expect(InlineSvg::StaticAssetFinder.find_asset('some-file').pathname).to eq(pathname)
2525
end
2626
end
2727
end

spec/webpack_asset_finder_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
stub_const('Shakapacker', double('Shakapacker').as_null_object)
1010
expect(Shakapacker.manifest).to receive(:lookup).with('some-file').and_return(nil)
1111

12-
expect(described_class.find_asset('some-file').pathname).to be_nil
12+
expect(InlineSvg::WebpackAssetFinder.find_asset('some-file').pathname).to be_nil
1313
end
1414
end
1515
end

0 commit comments

Comments
 (0)