Removed warnings

removed alloc of static arrays with dynamic sizes on stack, and return of stack array values
Signed-off-by: Alexandre Eichenberger <[email protected]>

Author: AlexandreEichenberger

src/Accelerators/NNPA/Support/Stickify/Stickify.cpp

@@ -969,7 +969,9 @@ zdnn_status transform_ztensor(const void *in_buf, zdnn_ztensor *ztensor) {
       fields_to_convert = ztensor->transformed_desc->dim2;
 
       // convert_data_format() will dump the converted entries here
-      uint16_t temp_buff[fields_to_convert];
+      uint16_t *temp_buff =
+          (uint16_t *)malloc(fields_to_convert * sizeof(uint16_t));
+      assert(temp_buff && "failed to allocate temp buff");
 
       // number of bytes to jump from the beginning of the last C-stick to the
       // next page-boundary
@@ -1057,7 +1059,8 @@ zdnn_status transform_ztensor(const void *in_buf, zdnn_ztensor *ztensor) {
         // done with all the C/H/W, go to the next n
         output_offset = out_offset_n + bytes_per_n;
       }
-    }
+      free(temp_buff);
+    } // End of if NCHW
   } else if (ztensor->transformed_desc->layout == ZDNN_HWCK) {
 
     uint64_t bytes_per_h =
@@ -1420,7 +1423,8 @@ zdnn_status stickify(zdnn_ztensor *ztensor, ...) {
 
       // Save the gate data for slicing later.
       // (e.g., LSTM) va_arg order: F (FWD,BWD), I (FWD,BWD), C...etc.
-      void *gate_data[num_gates];
+      void **gate_data = (void **)malloc(num_gates * sizeof(void *));
+      assert(gate_data && "failed to allocate data");
       for (uint8_t i = 0; i < num_gates; i++) {
         gate_data[i] = va_arg(argptr, void *);
       }
@@ -1508,7 +1512,7 @@ zdnn_status stickify(zdnn_ztensor *ztensor, ...) {
         // Set that the output ztensor has completed transformation.
         ztensor->is_transformed = true;
       }
-
+      free(gate_data);
     } while (false);
 
   } else {

src/Dialect/ONNX/DialectBuilder.cpp

@@ -555,7 +555,7 @@ TensorType OnnxBuilder::toTensor(Type input) const {
   return RankedTensorType::get(aTy.getShape(), elementTy);
 }
 
-TypeRange OnnxBuilder::toTensors(TypeRange inputs) const {
+SmallVector<Type, 4> OnnxBuilder::toTensors(TypeRange inputs) const {
   if (llvm::all_of(inputs, [](Type t) { return (mlir::isa<TensorType>(t)); }))
     return inputs;
   assert(llvm::all_of(inputs, [](Type t) {
@@ -570,7 +570,7 @@ TypeRange OnnxBuilder::toTensors(TypeRange inputs) const {
     }
     resultTypes.emplace_back(RankedTensorType::get(aTy.getShape(), elementTy));
   }
-  return TypeRange(resultTypes);
+  return resultTypes;
 }
 
 Value OnnxBuilder::toMemref(Value input) const {

src/Dialect/ONNX/DialectBuilder.hpp

@@ -232,7 +232,7 @@ struct OnnxBuilder : DialectBuilder {
   // Convert a Type to TensorType if it is of MemRefType.
   mlir::TensorType toTensor(mlir::Type input) const;
   // Convert Type to TypeRange of TensorType if it is of MemRefType.
-  mlir::TypeRange toTensors(mlir::TypeRange inputs) const;
+  mlir::SmallVector<mlir::Type, 4> toTensors(mlir::TypeRange inputs) const;
   // Convert a Value to MemrefType if it is of TensorType.
   mlir::Value toMemref(mlir::Value input) const;