Skip to content

Commit e33977e

Browse files
authored
Use withResolver API in gRPC reporter (#3078)
* Use withResolver API in gRPC reporter Signed-off-by: Pavol Loffay <[email protected]> * Use manual Signed-off-by: Pavol Loffay <[email protected]> * fmt Signed-off-by: Pavol Loffay <[email protected]>
1 parent 3f96a96 commit e33977e

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

cmd/agent/app/reporter/grpc/builder.go

+2-12
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ import (
1818
"context"
1919
"errors"
2020
"fmt"
21-
"strconv"
2221
"strings"
23-
"time"
2422

2523
grpc_retry "github.com/grpc-ecosystem/go-grpc-middleware/retry"
2624
"github.com/uber/jaeger-lib/metrics"
@@ -82,7 +80,8 @@ func (b *ConnBuilder) CreateConnection(logger *zap.Logger, mFactory metrics.Fact
8280
return nil, errors.New("at least one collector hostPort address is required when resolver is not available")
8381
}
8482
if len(b.CollectorHostPorts) > 1 {
85-
r, _ := generateAndRegisterManualResolver()
83+
r := manual.NewBuilderWithScheme("jaeger_manual")
84+
dialOptions = append(dialOptions, grpc.WithResolvers(r))
8685
var resolvedAddrs []resolver.Address
8786
for _, addr := range b.CollectorHostPorts {
8887
resolvedAddrs = append(resolvedAddrs, resolver.Address{Addr: addr})
@@ -125,12 +124,3 @@ func (b *ConnBuilder) CreateConnection(logger *zap.Logger, mFactory metrics.Fact
125124

126125
return conn, nil
127126
}
128-
129-
// generateAndRegisterManualResolver was removed from grpc.
130-
// Copied here to keep behavior the same.
131-
func generateAndRegisterManualResolver() (*manual.Resolver, func()) {
132-
scheme := strconv.FormatInt(time.Now().UnixNano(), 36)
133-
r := manual.NewBuilderWithScheme(scheme)
134-
resolver.Register(r)
135-
return r, func() { resolver.UnregisterForTesting(scheme) }
136-
}

0 commit comments

Comments
 (0)