add action test

Signed-off-by: zzzk1 <[email protected]>

Author: zhengkezhou1

cmd/es-rollover/app/init/action.go

@@ -60,7 +60,7 @@ func (c Action) Do() error {
 		if !policyExist {
 			err := createDefaultILMPolicy(c.ILMClient, c.Config.ILMPolicyName)
 			if err != nil {
-				return fmt.Errorf("ILM policy %s Create/Update failed %w", c.Config.ILMPolicyName, err)
+				return fmt.Errorf("ILM policy %s Create/Update failed", c.Config.ILMPolicyName)
 			}
 		}
 	}

cmd/es-rollover/app/init/action_test.go

@@ -110,12 +110,19 @@ func TestRolloverAction(t *testing.T) {
 			},
 		},
 		{
-			name: "ilm doesnt exist",
-			setupCallExpectations: func(_ *mocks.IndexAPI, clusterClient *mocks.ClusterAPI, ilmClient *mocks.IndexManagementLifecycleAPI) {
+			name: "create ILM policy",
+			setupCallExpectations: func(indexClient *mocks.IndexAPI, clusterClient *mocks.ClusterAPI, ilmClient *mocks.IndexManagementLifecycleAPI) {
 				clusterClient.On("Version").Return(uint(7), nil)
 				ilmClient.On("Exists", "myilmpolicy").Return(false, nil)
+				indexClient.On("CreateTemplate", mock.Anything, "jaeger-span").Return(nil)
+				indexClient.On("CreateIndex", "jaeger-span-archive-000001").Return(nil)
+				indexClient.On("GetJaegerIndices", "").Return([]client.Index{}, nil)
+				indexClient.On("CreateAlias", []client.Alias{
+					{Index: "jaeger-span-archive-000001", Name: "jaeger-span-archive-read", IsWriteIndex: false},
+					{Index: "jaeger-span-archive-000001", Name: "jaeger-span-archive-write", IsWriteIndex: true},
+				}).Return(nil)
+				ilmClient.On("CreateOrUpdate", "myilmpolicy", mock.Anything).Return(nil)
 			},
-			expectedErr: errors.New("ILM policy myilmpolicy doesn't exist in Elasticsearch. Please create it and re-run init"),
 			config: Config{
 				Config: app.Config{
 					Archive:       true,

plugin/storage/integration/elasticsearch_test.go

@@ -263,20 +263,16 @@ func TestElasticsearchStorage_ILMPolicy(t *testing.T) {
 		ilmPolicyExistsResponse, err := s.v8Client.ILM.GetLifecycle(request)
 		require.NoError(t, err)
 		assert.Equal(t, 200, ilmPolicyExistsResponse.StatusCode)
-	} else {
-		// nothing
 	}
-	s.cleanEsILMPolicy(t, ilmPolicy)
+	s.cleanEsILMPolicy(t)
 }
 
-func (s *ESStorageIntegration) cleanEsILMPolicy(t *testing.T, policy string) error {
+func (s *ESStorageIntegration) cleanEsILMPolicy(t *testing.T) error {
 	version, err := s.getVersion()
 	require.NoError(t, err)
 	if version == 8 {
 		_, err := s.v8Client.ILM.RemovePolicy(ilmPolicy)
 		require.NoError(t, err)
-	} else {
-		// nothing
 	}
 	return nil
 }