Skip to content

Commit 56fecab

Browse files
authored
AbstractShadowRenderer.setRenderBackFacesShadows(): Change input type Boolean -> boolean (#2206)
AbstractShadowFilter.setRenderBackFacesShadows: change input type from Boolean to boolean
1 parent 14bb821 commit 56fecab

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

jme3-core/src/main/java/com/jme3/shadow/AbstractShadowFilter.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2009-2021 jMonkeyEngine
2+
* Copyright (c) 2009-2024 jMonkeyEngine
33
* All rights reserved.
44
*
55
* Redistribution and use in source and binary forms, with or without
@@ -108,7 +108,6 @@ protected void preFrame(float tpf) {
108108
material.setMatrix4("ViewProjectionMatrixInverse", viewPort.getCamera().getViewProjectionMatrix().invert());
109109
Matrix4f m = viewPort.getCamera().getViewProjectionMatrix();
110110
material.setVector4("ViewProjectionMatrixRow2", tmpv.set(m.m20, m.m21, m.m22, m.m23));
111-
112111
}
113112

114113
@Override
@@ -258,7 +257,7 @@ final public void setEdgeFilteringMode(EdgeFilteringMode filterMode) {
258257
/**
259258
*
260259
* !! WARNING !! this parameter is defaulted to true for the ShadowFilter.
261-
* Setting it to true, may produce edges artifacts on shadows. *
260+
* Setting it to true, may produce edges artifacts on shadows.
262261
*
263262
* Set to true if you want back faces shadows on geometries.
264263
* Note that back faces shadows will be blended over dark lighten areas and may produce overly dark lighting.
@@ -272,7 +271,7 @@ final public void setEdgeFilteringMode(EdgeFilteringMode filterMode) {
272271
*
273272
* @param renderBackFacesShadows true or false.
274273
*/
275-
public void setRenderBackFacesShadows(Boolean renderBackFacesShadows) {
274+
public void setRenderBackFacesShadows(boolean renderBackFacesShadows) {
276275
shadowRenderer.setRenderBackFacesShadows(renderBackFacesShadows);
277276
}
278277

@@ -294,7 +293,6 @@ public RenderState getPreShadowForcedRenderState() {
294293
return shadowRenderer.getPreShadowForcedRenderState();
295294
}
296295

297-
298296
/**
299297
* returns the edge filtering mode
300298
*

jme3-core/src/main/java/com/jme3/shadow/AbstractShadowRenderer.java

+4-8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2009-2021 jMonkeyEngine
2+
* Copyright (c) 2009-2024 jMonkeyEngine
33
* All rights reserved.
44
*
55
* Redistribution and use in source and binary forms, with or without
@@ -145,12 +145,10 @@ protected AbstractShadowRenderer() {
145145
* maps the more quality, the fewer fps).
146146
*/
147147
protected AbstractShadowRenderer(AssetManager assetManager, int shadowMapSize, int nbShadowMaps) {
148-
149148
this.assetManager = assetManager;
150149
this.nbShadowMaps = nbShadowMaps;
151150
this.shadowMapSize = shadowMapSize;
152151
init(assetManager, nbShadowMaps, shadowMapSize);
153-
154152
}
155153

156154
private void init(AssetManager assetManager, int nbShadowMaps, int shadowMapSize) {
@@ -430,7 +428,6 @@ public void postQueue(RenderQueue rq) {
430428
renderManager.setForcedMaterial(null);
431429
renderManager.setForcedTechnique(null);
432430
renderManager.setCamera(viewPort.getCamera(), false);
433-
434431
}
435432

436433
protected void renderShadowMap(int shadowMapIndex) {
@@ -806,12 +803,12 @@ public RenderState getPreShadowForcedRenderState() {
806803
*
807804
* @param renderBackFacesShadows true or false.
808805
*/
809-
public void setRenderBackFacesShadows(Boolean renderBackFacesShadows) {
806+
public void setRenderBackFacesShadows(boolean renderBackFacesShadows) {
810807
this.renderBackFacesShadows = renderBackFacesShadows;
811-
if(renderBackFacesShadows) {
808+
if (renderBackFacesShadows) {
812809
getPreShadowForcedRenderState().setPolyOffset(5, 3);
813810
getPreShadowForcedRenderState().setFaceCullMode(RenderState.FaceCullMode.Back);
814-
}else{
811+
} else {
815812
getPreShadowForcedRenderState().setPolyOffset(0, 0);
816813
getPreShadowForcedRenderState().setFaceCullMode(RenderState.FaceCullMode.Front);
817814
}
@@ -864,7 +861,6 @@ public void read(JmeImporter im) throws IOException {
864861
init(assetManager, nbShadowMaps, (int) shadowMapSize);
865862
edgesThickness = ic.readFloat("edgesThickness", 1.0f);
866863
postshadowMat.setFloat("PCFEdge", edgesThickness);
867-
868864
}
869865

870866
/**

0 commit comments

Comments
 (0)