Skip to content

Commit d5331c9

Browse files
authored
Merge pull request continuedev#3922 from continuedev/nate/ci3
update ci
2 parents bda541a + 35dfe37 commit d5331c9

File tree

1 file changed

+1
-57
lines changed

1 file changed

+1
-57
lines changed

.github/workflows/pr_checks.yaml

+1-57
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: PR checks
22

33
on:
4-
pull_request_target:
4+
pull_request:
55
branches:
66
- main
77
paths:
@@ -22,21 +22,10 @@ on:
2222
- ".github/workflows/**"
2323

2424
jobs:
25-
validate-pr:
26-
runs-on: ubuntu-latest
27-
environment: tests-requiring-secrets
28-
steps:
29-
- uses: actions/checkout@v4
30-
3125
install-root:
32-
needs: validate-pr
3326
runs-on: ubuntu-latest
3427
steps:
3528
- uses: actions/checkout@v4
36-
with:
37-
ref: ${{ github.event.pull_request.head.sha }}
38-
# This is important - it switches from the base repo to the fork
39-
repository: ${{ github.event.pull_request.head.repo.full_name }}
4029

4130
- uses: actions/setup-node@v4
4231
with:
@@ -57,9 +46,6 @@ jobs:
5746
runs-on: ubuntu-latest
5847
steps:
5948
- uses: actions/checkout@v4
60-
with:
61-
ref: ${{ github.event.pull_request.head.sha }}
62-
repository: ${{ github.event.pull_request.head.repo.full_name }}
6349

6450
- uses: actions/setup-node@v4
6551
with:
@@ -86,12 +72,8 @@ jobs:
8672
core-checks:
8773
needs: install-core
8874
runs-on: ubuntu-latest
89-
environment: tests-requiring-secrets
9075
steps:
9176
- uses: actions/checkout@v4
92-
with:
93-
ref: ${{ github.event.pull_request.head.sha }}
94-
repository: ${{ github.event.pull_request.head.repo.full_name }}
9577

9678
- uses: actions/setup-node@v4
9779
with:
@@ -122,9 +104,6 @@ jobs:
122104
runs-on: ubuntu-latest
123105
steps:
124106
- uses: actions/checkout@v4
125-
with:
126-
ref: ${{ github.event.pull_request.head.sha }}
127-
repository: ${{ github.event.pull_request.head.repo.full_name }}
128107

129108
- uses: actions/setup-node@v4
130109
with:
@@ -157,9 +136,6 @@ jobs:
157136
runs-on: ubuntu-latest
158137
steps:
159138
- uses: actions/checkout@v4
160-
with:
161-
ref: ${{ github.event.pull_request.head.sha }}
162-
repository: ${{ github.event.pull_request.head.repo.full_name }}
163139

164140
- uses: actions/setup-node@v4
165141
with:
@@ -191,9 +167,6 @@ jobs:
191167
runs-on: ubuntu-latest
192168
steps:
193169
- uses: actions/checkout@v4
194-
with:
195-
ref: ${{ github.event.pull_request.head.sha }}
196-
repository: ${{ github.event.pull_request.head.repo.full_name }}
197170

198171
- uses: actions/setup-node@v4
199172
with:
@@ -231,9 +204,6 @@ jobs:
231204
runs-on: ubuntu-latest
232205
steps:
233206
- uses: actions/checkout@v4
234-
with:
235-
ref: ${{ github.event.pull_request.head.sha }}
236-
repository: ${{ github.event.pull_request.head.repo.full_name }}
237207

238208
- uses: actions/setup-node@v4
239209
with:
@@ -268,9 +238,6 @@ jobs:
268238
runs-on: ubuntu-latest
269239
steps:
270240
- uses: actions/checkout@v4
271-
with:
272-
ref: ${{ github.event.pull_request.head.sha }}
273-
repository: ${{ github.event.pull_request.head.repo.full_name }}
274241

275242
- uses: actions/setup-node@v4
276243
with:
@@ -303,9 +270,6 @@ jobs:
303270
runs-on: ubuntu-latest
304271
steps:
305272
- uses: actions/checkout@v4
306-
with:
307-
ref: ${{ github.event.pull_request.head.sha }}
308-
repository: ${{ github.event.pull_request.head.repo.full_name }}
309273

310274
- uses: actions/setup-node@v4
311275
with:
@@ -333,9 +297,6 @@ jobs:
333297
test_file_matrix: ${{ steps.vscode-get-test-file-matrix.outputs.test_file_matrix }}
334298
steps:
335299
- uses: actions/checkout@v4
336-
with:
337-
ref: ${{ github.event.pull_request.head.sha }}
338-
repository: ${{ github.event.pull_request.head.repo.full_name }}
339300

340301
- name: Cache node modules
341302
uses: actions/cache@v3
@@ -363,9 +324,6 @@ jobs:
363324
needs: [install-vscode, install-core]
364325
steps:
365326
- uses: actions/checkout@v4
366-
with:
367-
ref: ${{ github.event.pull_request.head.sha }}
368-
repository: ${{ github.event.pull_request.head.repo.full_name }}
369327

370328
- uses: actions/setup-node@v4
371329
with:
@@ -399,9 +357,6 @@ jobs:
399357
needs: [install-vscode, install-core]
400358
steps:
401359
- uses: actions/checkout@v4
402-
with:
403-
ref: ${{ github.event.pull_request.head.sha }}
404-
repository: ${{ github.event.pull_request.head.repo.full_name }}
405360

406361
- uses: actions/setup-node@v4
407362
with:
@@ -443,17 +398,13 @@ jobs:
443398
]
444399
runs-on: ubuntu-latest
445400
# Tests requiring secrets need approval from maintainers
446-
environment: tests-requiring-secrets
447401
strategy:
448402
fail-fast: false
449403
matrix:
450404
test_file: ${{ fromJson(needs.vscode-get-test-file-matrix.outputs.test_file_matrix) }}
451405
command: ["e2e:ci:run", "e2e:ci:run-yaml"]
452406
steps:
453407
- uses: actions/checkout@v4
454-
with:
455-
ref: ${{ github.event.pull_request.head.sha }}
456-
repository: ${{ github.event.pull_request.head.repo.full_name }}
457408

458409
- uses: actions/setup-node@v4
459410
with:
@@ -517,9 +468,6 @@ jobs:
517468
runs-on: ubuntu-latest
518469
steps:
519470
- uses: actions/checkout@v4
520-
with:
521-
ref: ${{ github.event.pull_request.head.sha }}
522-
repository: ${{ github.event.pull_request.head.repo.full_name }}
523471

524472
- uses: actions/setup-node@v4
525473
with:
@@ -552,10 +500,6 @@ jobs:
552500
runs-on: ubuntu-latest
553501
steps:
554502
- uses: actions/checkout@v4
555-
with:
556-
ref: ${{ github.event.pull_request.head.sha }}
557-
repository: ${{ github.event.pull_request.head.repo.full_name }}
558-
559503
- uses: actions/cache@v4
560504
with:
561505
path: core/node_modules

0 commit comments

Comments
 (0)