Skip to content

Commit 5d4a724

Browse files
drammocktrallard
authored andcommitted
Install sphinx test dependencies in all CI testing jobs (pydata#1772)
* CI: install sphinx test deps always * fix it right this time * pin sphinx<7.3 for site builds * Fix Sphinx version * Pin Sphinx in pyproject.toml * bump ablog; unpin sphinx --------- Co-authored-by: Tania Allard <[email protected]>
1 parent daaab21 commit 5d4a724

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

.github/workflows/tests.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,16 @@ jobs:
4545
matrix:
4646
os: [ubuntu-latest]
4747
python-version: ["3.9", "3.10", "3.11", "3.12"]
48-
sphinx-version: [""]
48+
sphinx-version: ["rls"]
4949
include:
5050
# macos test
5151
- os: macos-latest
5252
python-version: "3.12"
53+
sphinx-version: "rls"
5354
# windows test
5455
- os: windows-latest
5556
python-version: "3.12"
57+
sphinx-version: "rls"
5658
# old Sphinx test
5759
- os: ubuntu-latest
5860
python-version: "3.9"

pyproject.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ dynamic = ["version"]
2020
readme = "README.md"
2121
requires-python = ">=3.9"
2222
dependencies = [
23-
"sphinx>=5.0",
23+
"sphinx>=5",
2424
"beautifulsoup4",
2525
"docutils!=0.17.0",
2626
"packaging",
@@ -59,7 +59,7 @@ doc = [
5959
"sphinx-autoapi>=3.0.0",
6060
# For examples section
6161
"myst-parser",
62-
"ablog>=0.11.0rc2",
62+
"ablog>=0.11.8",
6363
"jupyter_sphinx",
6464
"pandas",
6565
"plotly",

tools/github_actions_install.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
# ($2) is an extra dependency (currently just nox on one run)
55
set -eo pipefail
66
export PYTHONUTF8=1
7-
if [[ "$SPHINX_VERSION" == "" ]]; then
8-
SPHINX_INSTALL=""
7+
if [[ "$SPHINX_VERSION" == "rls" ]]; then
8+
SPHINX_INSTALL="sphinx[test]"
99
elif [[ "$SPHINX_VERSION" == "dev" ]]; then
1010
SPHINX_INSTALL="sphinx[test]@https://codeload.github.com/sphinx-doc/sphinx/zip/refs/heads/master"
1111
elif [[ "$SPHINX_VERSION" == "old" ]]; then
1212
SPHINX_INSTALL="sphinx[test]==6.1.0"
13-
else # not used currently but easy enough
14-
SPHINX_INSTALL="sphinx[test]==$SPHINX_VERSION"
13+
else # for the "build site" jobs
14+
SPHINX_INSTALL="sphinx<7.3"
1515
fi
1616
set -x # print commands
1717
python -m pip install --upgrade pip wheel setuptools

0 commit comments

Comments
 (0)