Adds a redis reliable queue implementation (tgstation#133)

* adds project to vscode rust-analyzer config
it asked me to

* redis reliable queue implementation

* readme

* cleanup

* shit fixed

* proper redis response handling for lpop

* more clean

* okay better handling i GUESS

* updated redis crate, all my tests pass
breaking changes don't apply either

* update the cargo lock to 2.0.0

* ignore clippy for the redis_lpush match return

* fixes cellularnoise clippy lints

Author: ZeWaka

.vscode/settings.json

@@ -1,3 +1,6 @@
 {
-    "rust-analyzer.cargo.target": "i686-pc-windows-msvc"
+    "rust-analyzer.cargo.target": "i686-pc-windows-msvc",
+    "rust-analyzer.linkedProjects": [
+        ".\\Cargo.toml"
+    ]
 }

Cargo.lock

@@ -37,7 +37,7 @@ png = { version = "0.17", optional = true }
 image = { version = "0.24", optional = true, default-features = false, features = ["png"] }
 git2 = { version = "0.17.1", optional = true, default-features = false }
 noise = { version = "0.8", optional = true }
-redis = { version = "0.21", optional = true }
+redis = { version = "0.23", optional = true }
 reqwest = { version = "0.11", optional = true, default-features = false, features = [
     "blocking",
     "rustls-tls",
@@ -103,6 +103,7 @@ hash = [
 ]
 pathfinder = ["num", "pathfinding", "serde", "serde_json"]
 redis_pubsub = ["flume", "redis", "serde", "serde_json"]
+redis_reliablequeue = ["flume", "redis", "serde", "serde_json"]
 unzip = ["zip", "jobs"]
 worleynoise = ["rand", "rayon"]
 

Cargo.toml

@@ -104,6 +104,7 @@ Additional features are:
 * hash: Faster replacement for `md5`, support for SHA-1, SHA-256, and SHA-512. Requires OpenSSL on Linux.
 * pathfinder: An a* pathfinder used for finding the shortest path in a static node map. Not to be used for a non-static map.
 * redis_pubsub: Library for sending and receiving messages through Redis.
+* redis_reliablequeue: Library for using a reliable queue pattern through Redis.
 * unzip: Function to download a .zip from a URL and unzip it to a directory.
 * worleynoise: Function that generates a type of nice looking cellular noise, more expensive than cellularnoise
 

README.md

@@ -0,0 +1,38 @@
+/**
+ * Connects to a given redis server.
+ *
+ * Arguments:
+ * * addr - The address of the server, for example "redis://127.0.0.1/"
+ */
+#define rustg_redis_connect_rq(addr) RUSTG_CALL(RUST_G, "redis_connect_rq")(addr)
+/**
+ * Disconnects from a previously connected redis server
+ */
+/proc/rustg_redis_disconnect_rq() return RUSTG_CALL(RUST_G, "redis_disconnect_rq")()
+/**
+ * https://redis.io/commands/lpush/
+ *
+ * Arguments
+ * * key (string) - The key to use
+ * * elements (list) - The elements to push, use a list even if there's only one element.
+ */
+#define rustg_redis_lpush(key, elements) RUSTG_CALL(RUST_G, "redis_lpush")(key, json_encode(elements))
+/**
+ * https://redis.io/commands/lrange/
+ *
+ * Arguments
+ * * key (string) - The key to use
+ * * start (string) - The zero-based index to start retrieving at
+ * * stop (string) - The zero-based index to stop retrieving at (inclusive)
+ */
+#define rustg_redis_lrange(key, start, stop) RUSTG_CALL(RUST_G, "redis_lrange")(key, start, stop)
+/**
+ * https://redis.io/commands/lpop/
+ *
+ * Arguments
+ * * key (string) - The key to use
+ * * count (string|null) - The amount to pop off the list, pass null to omit (thus just 1)
+ *
+ * Note: `count` was added in Redis version 6.2.0
+ */
+#define rustg_redis_lpop(key, count) RUSTG_CALL(RUST_G, "redis_lpop")(key, count)

dmsrc/redis-reliablequeue.dm

@@ -20,7 +20,11 @@ struct AhoCorasickOptions {
 impl AhoCorasickOptions {
     fn auto_configure_and_build(&self, patterns: &[String]) -> AhoCorasick {
         AhoCorasickBuilder::new()
-            .start_kind(if self.anchored { StartKind::Anchored } else { StartKind::Unanchored })
+            .start_kind(if self.anchored {
+                StartKind::Anchored
+            } else {
+                StartKind::Unanchored
+            })
             .ascii_case_insensitive(self.ascii_case_insensitive)
             .match_kind(self.match_kind)
             .build(patterns)

src/acreplace.rs

@@ -27,7 +27,6 @@ fn noise_gen(
         .map(|x| {
             let mut rng = rand::thread_rng();
             (0..height + 3)
-                .into_iter()
                 .map(|y| {
                     if x == 0 || y == 0 || x == width + 2 || y == height + 2 {
                         return false;
@@ -39,12 +38,11 @@ fn noise_gen(
         .collect::<Vec<Vec<bool>>>();
 
     //then we smoothe it
-    (0..smoothing_level).into_iter().for_each(|_| {
+    (0..smoothing_level).for_each(|_| {
         let replace_vec = (0..width + 3)
             .into_par_iter()
             .map(|x| {
                 (0..height + 3)
-                    .into_iter()
                     .map(|y| {
                         if x == 0 || y == 0 || x == width + 2 || y == height + 2 {
                             return false;
@@ -77,7 +75,6 @@ fn noise_gen(
         .into_par_iter()
         .map(|x| {
             (1..height + 1)
-                .into_iter()
                 .map(|y| filled_vec[x][y])
                 .collect::<Vec<bool>>()
         })

src/cellularnoise.rs

@@ -34,6 +34,8 @@ pub mod noise_gen;
 pub mod pathfinder;
 #[cfg(feature = "redis_pubsub")]
 pub mod redis_pubsub;
+#[cfg(feature = "redis_reliablequeue")]
+pub mod redis_reliablequeue;
 #[cfg(feature = "sql")]
 pub mod sql;
 #[cfg(feature = "time")]