more rules

Author: Laoujin

frontend/.eslintrc.json

@@ -10,7 +10,23 @@
     "no-multi-spaces": "error",
     "no-multiple-empty-lines": ["error", { "max": 8, "maxEOF": 1 }],
     "eol-last": ["error", "always"],
-    "indent": ["error", 2, { "SwitchCase": 1 }]
+    "indent": ["error", 2, { "SwitchCase": 1 }],
+    // "curly": ["error", "multi-line"]
+    "dot-notation": ["error", { "allowKeywords": true }],
+    "eqeqeq": ["error", "always", { "null": "ignore" }],
+    "no-lone-blocks": "error",
+    "no-octal": "error",
+    "no-redeclare": "error",
+    "no-self-compare": "error",
+    "yoda": "error",
+    "no-debugger": "warn",
+    "no-dupe-keys": "error",
+    "no-duplicate-case": "error",
+    "no-extra-semi": "error",
+    "no-unreachable": "warn",
+    "arrow-spacing": ["error", { "before": true, "after": true }],
+    "no-useless-computed-key": "error",
+    "no-var": "error"
   },
   "overrides": [
     {

frontend/src/components/hooks/useEntityChangedToast.tsx

@@ -3,7 +3,7 @@ import { socketService } from "../socketio/SocketService";
 
 function useEntityChangedToast(entityId: string | null | undefined, entityType: string | null | undefined = null) {
   useEffect(() => {
-    var subs: undefined | (() => void);
+    let subs: undefined | (() => void);
     if (entityId || entityType) {
       subs = socketService.enableToastsForEntity(entityId, entityType);
     }

frontend/src/components/socketio/SocketService.ts

@@ -11,8 +11,8 @@ import { baseUrl } from "../../config-front";
 function createSocketService() {
   const socket = io(baseUrl);
 
-  var socketId: undefined | string = undefined;
-  var initialized = false;
+  let socketId: undefined | string = undefined;
+  let initialized = false;
 
   socket.on("connect", () => {
     console.log(`Socketio: Connected to server with id=${socket.id}`);
@@ -24,10 +24,7 @@ function createSocketService() {
       return;
     }
 
-    function registerHandlerForEventType(
-      eventType: SocketEventTypes,
-      dispatch: Dispatch<any>
-    ) {
+    function registerHandlerForEventType(eventType: SocketEventTypes) {
       socket.on(eventType, (eventPayload) => {
         if (eventPayload.sourceSocketId === socketId) {
           // console.log("Socket.io: Event ignored => sourceSocketId is equal to current socket id.");
@@ -66,9 +63,9 @@ function createSocketService() {
       });
     }
 
-    registerHandlerForEventType(SocketEventTypes.EntityCreated, dispatch);
-    registerHandlerForEventType(SocketEventTypes.EntityUpdated, dispatch);
-    registerHandlerForEventType(SocketEventTypes.EntityDeleted, dispatch);
+    registerHandlerForEventType(SocketEventTypes.EntityCreated);
+    registerHandlerForEventType(SocketEventTypes.EntityUpdated);
+    registerHandlerForEventType(SocketEventTypes.EntityDeleted);
 
     initialized = true;
   }
@@ -91,7 +88,7 @@ function createSocketService() {
     entityId: string | null | undefined,
     entityType: string | null | undefined
   ) {
-    var unsubscriptions: (() => void)[] = [];
+    const unsubscriptions: (() => void)[] = [];
 
     function registerHandlerForToastEventType(eventType: SocketEventTypes) {
       const handleEvent = (msg: EntityEventPayload) => {

frontend/src/components/users/authService.ts

@@ -96,7 +96,7 @@ class AuthService implements IAuthService {
   }
 
   entryPathname = document.location.pathname;
-};
+}
 
 
 export const authService = new AuthService();