Skip to content

Commit dc41a3a

Browse files
committed
Do not use the deprecated Buffer() constructor
Fixes: #240 Refs: nodejs/citgm#605 Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
1 parent 5aee216 commit dc41a3a

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"README.md"
2020
],
2121
"devDependencies": {
22+
"safer-buffer": "^2.1.2",
2223
"standard": "^8.6.0",
2324
"tap": "^10.5.1"
2425
}

test/not-string.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
var Buffer = require('safer-buffer').Buffer
12
var parser = require('../').parser(true)
23
var t = require('tap')
34
t.plan(1)
45
parser.onopentag = function (node) {
56
t.same(node, { name: 'x', attributes: {}, isSelfClosing: false })
67
}
7-
var xml = new Buffer('<x>y</x>')
8+
var xml = Buffer.from('<x>y</x>')
89
parser.write(xml).close()

test/utf8-split.js

+14-13
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,35 @@
1+
var Buffer = require('safer-buffer').Buffer
12
var tap = require('tap')
23
var saxStream = require('../lib/sax').createStream()
34

4-
var b = new Buffer('误')
5+
var b = Buffer.from('误')
56

67
saxStream.on('text', function (text) {
78
tap.equal(text, b.toString())
89
})
910

10-
saxStream.write(new Buffer('<test><a>'))
11+
saxStream.write(Buffer.from('<test><a>'))
1112
saxStream.write(b.slice(0, 1))
1213
saxStream.write(b.slice(1))
13-
saxStream.write(new Buffer('</a><b>'))
14+
saxStream.write(Buffer.from('</a><b>'))
1415
saxStream.write(b.slice(0, 2))
1516
saxStream.write(b.slice(2))
16-
saxStream.write(new Buffer('</b><c>'))
17+
saxStream.write(Buffer.from('</b><c>'))
1718
saxStream.write(b)
18-
saxStream.write(new Buffer('</c>'))
19-
saxStream.write(Buffer.concat([new Buffer('<d>'), b.slice(0, 1)]))
20-
saxStream.end(Buffer.concat([b.slice(1), new Buffer('</d></test>')]))
19+
saxStream.write(Buffer.from('</c>'))
20+
saxStream.write(Buffer.concat([Buffer.from('<d>'), b.slice(0, 1)]))
21+
saxStream.end(Buffer.concat([b.slice(1), Buffer.from('</d></test>')]))
2122

2223
var saxStream2 = require('../lib/sax').createStream()
2324

2425
saxStream2.on('text', function (text) {
2526
tap.equal(text, '�')
2627
})
2728

28-
saxStream2.write(new Buffer('<root>'))
29-
saxStream2.write(new Buffer('<e>'))
30-
saxStream2.write(new Buffer([0xC0]))
31-
saxStream2.write(new Buffer('</e>'))
32-
saxStream2.write(Buffer.concat([new Buffer('<f>'), b.slice(0, 1)]))
33-
saxStream2.write(new Buffer('</root>'))
29+
saxStream2.write(Buffer.from('<root>'))
30+
saxStream2.write(Buffer.from('<e>'))
31+
saxStream2.write(Buffer.from([0xC0]))
32+
saxStream2.write(Buffer.from('</e>'))
33+
saxStream2.write(Buffer.concat([Buffer.from('<f>'), b.slice(0, 1)]))
34+
saxStream2.write(Buffer.from('</root>'))
3435
saxStream2.end()

0 commit comments

Comments
 (0)