Skip to content

Commit 849d672

Browse files
committed
Always load graceful-fs BEFORE tap in tests
This prevents issues where a graceful-fs deep in tap's dep chain ends up hijacking our test environment variable.
1 parent c7b3374 commit 849d672

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

test/chown-er-ok.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
var t = require('tap')
21
var realFs = require('fs')
32

43
var methods = ['chown', 'chownSync', 'chmod', 'chmodSync']
@@ -26,6 +25,7 @@ function makeErr (path, method) {
2625
}
2726

2827
var fs = require('../')
28+
var t = require('tap')
2929

3030
var errs = ['ENOSYS', 'EINVAL', 'EPERM']
3131
t.plan(errs.length * methods.length)

test/close.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
var test = require('tap').test
21
var fs$close = require('fs').close;
32
var fs$closeSync = require('fs').closeSync;
43
var fs = require('../');
4+
var test = require('tap').test
55

66
test('`close` is patched correctly', function(t) {
77
t.notEqual(fs.close, fs$close, 'patch close');

test/enoent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// this test makes sure that various things get enoent, instead of
22
// some other kind of throw.
33

4-
var t = require('tap')
54
var g = require('../')
65

76
var NODE_VERSION_MAJOR_WITH_BIGINT = 10
@@ -27,6 +26,7 @@ function nodeSupportsBigInt () {
2726
return false
2827
}
2928

29+
var t = require('tap')
3030
var file = 'this file does not exist even a little bit'
3131
var methods = [
3232
['open', 'r'],

test/max-open.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var test = require('tap').test
21
var fs = require('../')
2+
var test = require('tap').test
33

44
test('open lots of stuff', function (t) {
55
// Get around EBADF from libuv by making sure that stderr is opened

test/open.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var test = require('tap').test
21
var fs = require('../')
2+
var test = require('tap').test
33

44
test('open an existing file works', function (t) {
55
var fd = fs.openSync(__filename, 'r')

test/readdir-options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var t = require("tap")
21
var fs = require("fs")
2+
var t = require("tap")
33

44
var currentTest
55

test/readdir-sort.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
var test = require("tap").test
21
var fs = require("fs")
32

43
var readdir = fs.readdir
@@ -9,6 +8,7 @@ fs.readdir = function(path, cb) {
98
}
109

1110
var g = require("../")
11+
var test = require("tap").test
1212

1313
test("readdir reorder", function (t) {
1414
g.readdir("whatevers", function (er, files) {

test/stats-uid-gid.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
2-
var test = require('tap').test
32
var util = require('util')
43
var fs = require('fs')
4+
var test = require('tap').test
55

66
// mock fs.statSync to return signed uids/gids
77
var realStatSync = fs.statSync

test/stats.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
var test = require('tap').test
21
var fs = require('fs')
32
var gfs = require('../graceful-fs.js')
3+
var test = require('tap').test
44

55
test('graceful fs uses same stats constructor as fs', function (t) {
66
t.equal(gfs.Stats, fs.Stats, 'should reference the same constructor')

0 commit comments

Comments
 (0)