Skip to content

merkledag.GetNodes has no way of failing #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whyrusleeping opened this issue Mar 1, 2015 · 2 comments
Closed

merkledag.GetNodes has no way of failing #843

whyrusleeping opened this issue Mar 1, 2015 · 2 comments
Labels
topic/bandwidth reduction Topic bandwidth reduction topic/bitswap Topic bitswap topic/cleanup Topic cleanup topic/merkledag Topic merkledag

Comments

@whyrusleeping
Copy link
Member

Other than a context cancel, dagserv.GetNodes has no way of failing due to blocks not being found. This needs to be thought about, should be discussed along with #830 as we need to decide when it is acceptable to say that a given block is 'not found' and we also need a way of returning that error case back up through the NodePromise stuff

@jbenet
Copy link
Member

jbenet commented Mar 3, 2015

We should have a set of errors that can be returned-- these are the equivalent of ICMP, or socket, or HTTP error codes for ipfs. Perhaps we can use interfaces (like the net package, with http://golang.org/pkg/net/#Error so users can cast and get some meaningful information) or codes like http.

@jbenet jbenet added topic/bitswap Topic bitswap topic/cleanup Topic cleanup topic/merkledag Topic merkledag topic/bandwidth reduction Topic bandwidth reduction labels Mar 28, 2015
@jbenet jbenet modified the milestone: Resource Constraints Mar 29, 2015
@whyrusleeping
Copy link
Member Author

the nodePromise Get can fail now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/bandwidth reduction Topic bandwidth reduction topic/bitswap Topic bitswap topic/cleanup Topic cleanup topic/merkledag Topic merkledag
Projects
None yet
Development

No branches or pull requests

2 participants