Skip to content

ipfs object put should accept stdin #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbenet opened this issue Feb 24, 2015 · 5 comments
Closed

ipfs object put should accept stdin #811

jbenet opened this issue Feb 24, 2015 · 5 comments
Assignees
Labels
help wanted Seeking public contribution on this issue

Comments

@jbenet
Copy link
Member

jbenet commented Feb 24, 2015

maybe:

ipfs object put - json

or move the encoding to a flag and default to json.

@jbenet
Copy link
Member Author

jbenet commented Feb 24, 2015

#810

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Feb 25, 2015
@cryptix cryptix self-assigned this Mar 7, 2015
@cryptix
Copy link
Contributor

cryptix commented Mar 7, 2015

Turn's out: there are no sharness test for all the 'ipfs object' commands and the --enc flag is broken.. it's not a flag...

$ ipfs object put --encoding=json test.json
Error: Argument 'encoding' is required

@jbenet
Copy link
Member Author

jbenet commented Mar 7, 2015

the object put cmd takes the encoding as arg -- i dont remember/know why (@mappum ?)

> ipfs object put --help

    ipfs object put <data> <encoding> - Stores input as a DAG object, outputs its key

ARGUMENTS:

    <data>     - Data to be stored as a DAG object
    <encoding> - Encoding type of <data>, either "protobuf" or "json"

so for now

ipfs object put test.json json 

agree we should try to use the flags.

@cryptix
Copy link
Contributor

cryptix commented Mar 7, 2015

aaah - yeah.. that works much better.

@cryptix
Copy link
Contributor

cryptix commented Mar 7, 2015

#882 is merged so i'll close this one.

@cryptix cryptix closed this as completed Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

3 participants