Skip to content

peer short tags are too short #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whyrusleeping opened this issue Feb 13, 2015 · 5 comments
Closed

peer short tags are too short #780

whyrusleeping opened this issue Feb 13, 2015 · 5 comments

Comments

@whyrusleeping
Copy link
Member

The shortened peer strings <QmWhyr> dont quite show enough of my peer ID's for me to tell which of the nodes im connected to. What do you think about skipping the first two letters (Qm) since theyre going to be the same across all peer IDs.

@techfreek
Copy link
Contributor

I'd like to take this on, however, I haven't seen the shortened peer strings. could you give me an example of a command that lists shortened peer strings?

@jbenet
Copy link
Member

jbenet commented Mar 2, 2015

What do you think about skipping the first two letters...

sgtm 👍

could you give me an example of a command that lists shortened peer strings?

this is mostly for logs and not exposed to users. though i think if you run ipfs dht query -v <hash> you'll see them. the relevant code is inside peer/ pkg somewhere.

@techfreek
Copy link
Contributor

@jbenet || @whyrusleeping, if I skip the first 2 characters, should it remain 6 characters long? Or should I bump it to 8 or something like that?

@whyrusleeping
Copy link
Member Author

If you skip the first two characters, keeping it at 6 characters seems fine to me.

@jbenet
Copy link
Member

jbenet commented Mar 2, 2015

btw, i just remembered that Qm will only be the same for sha256 peerIDs. our use of the shortened peerid is mostly for debugging anyway, so this may be ok. we can always revert back and bump to 8 chars if we have reason to.

@jbenet jbenet closed this as completed in ee449cb Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants