Skip to content

Improve bitswap testing interfaces #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whyrusleeping opened this issue Sep 2, 2016 · 3 comments
Closed

Improve bitswap testing interfaces #3181

whyrusleeping opened this issue Sep 2, 2016 · 3 comments
Labels
help wanted Seeking public contribution on this issue kind/test Testing work need/community-input Needs input from the wider community status/deferred Conscious decision to pause or backlog topic/bitswap Topic bitswap

Comments

@whyrusleeping
Copy link
Member

Right now, its pretty annoying to write a new bitswap test. There is a lot of setup required to create a bitswap instance, this doesnt necessarily always have to be. We should rethink how a bitswap instance is created, instantiated and hooked up to a network.
@whyrusleeping whyrusleeping added topic/bitswap Topic bitswap backwards incompatible: protocol need/community-input Needs input from the wider community labels Sep 2, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Sep 2, 2016

@whyrusleeping are labels correct here?

@whyrusleeping
Copy link
Member Author

hush

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@flyingzumwalt flyingzumwalt added the status/deferred Conscious decision to pause or backlog label Sep 26, 2016
@eingenito
Copy link
Contributor

Closing due to age and many changes to bitswap to allow for easier unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/test Testing work need/community-input Needs input from the wider community status/deferred Conscious decision to pause or backlog topic/bitswap Topic bitswap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flyingzumwalt @eingenito @whyrusleeping @Kubuxu