docs: clarify why 'ipfs id <peer>' in offline mode

lidel · lidel · commit 27432e6f642b · 2022-01-19T16:17:25.000+01:00
diff --git a/core/commands/id.go b/core/commands/id.go
@@ -23,7 +23,7 @@ import (
 	identify "github.com/libp2p/go-libp2p/p2p/protocol/identify"
 )
 
-const offlineIdErrorMessage = "'ipfs id' cannot query information on remote peers without a running daemon; use the --offline option instead."
+const offlineIdErrorMessage = "'ipfs id' cannot query information on remote peers without a running daemon; if you only want to convert --peerid-base, pass --offline option."
 
 type IdOutput struct {
 	ID              string
diff --git a/test/sharness/t0026-id.sh b/test/sharness/t0026-id.sh
@@ -54,7 +54,7 @@ test_expect_success "checking ID of self" '
   test_cmp expected-id actual-id
 '
 
-test_expect_success "checking ID of random peer offline" '
+test_expect_success "checking and converting ID of a random peer while offline" '
   # Peer ID taken from `t0140-swarm.sh` test.
   echo k2k4r8ncs1yoluq95unsd7x2vfhgve0ncjoggwqx9vyh3vl8warrcp15 > expected-id &&
   ipfs id -f "<id>\n" --peerid-base base36 --offline QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N > actual-id &&

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ import (`
`23`	`23`	`identify "github.com/libp2p/go-libp2p/p2p/protocol/identify"`
`24`	`24`	`)`
`25`	`25`
`26`		`-const offlineIdErrorMessage = "'ipfs id' cannot query information on remote peers without a running daemon; use the --offline option instead."`
	`26`	`+const offlineIdErrorMessage = "'ipfs id' cannot query information on remote peers without a running daemon; if you only want to convert --peerid-base, pass --offline option."`
`27`	`27`
`28`	`28`	`type IdOutput struct {`
`29`	`29`	`ID string`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ test_expect_success "checking ID of self" '`
`54`	`54`	`test_cmp expected-id actual-id`
`55`	`55`	`'`
`56`	`56`
`57`		`-test_expect_success "checking ID of random peer offline" '`
	`57`	`+test_expect_success "checking and converting ID of a random peer while offline" '`
`58`	`58`	# Peer ID taken from `t0140-swarm.sh` test.
`59`	`59`	`echo k2k4r8ncs1yoluq95unsd7x2vfhgve0ncjoggwqx9vyh3vl8warrcp15 > expected-id &&`
`60`	`60`	`ipfs id -f "<id>\n" --peerid-base base36 --offline QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N > actual-id &&`