fix: broken dnslink at /ipns/ipfs.io/blog/foo #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonome
approved these changes
Feb 11, 2020
lidel
force-pushed
the
fix/canonical-ipfs-blog-urls
branch
from
aed13fc to
069bc8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes broken DNSLink loads for
/ipns/ipfs.io/blog/*from local or public gateways.Without this, user stumbling upon https://ipfs.io/blog/2020-02-10-our-focus-for-2020/ will get redirected to http://127.0.0.1:8080/ipns/ipfs.io/blog/2020-02-10-our-focus-for-2020/ and get HTTP 404 error without any indication how to fix it, which is pretty bad experience:
ipfs resolve -r /ipns/ipfs.io/blog/2020-02-10-our-focus-for-2020/: no link named "2020-02-10-our-focus-for-2020" under bafybeics2j3x4qcn3365docj4f5xfe7gwlbakds7x3it63okc572imyb4eWider context: https://github.com/ipfs/blog/issues/360
cc @autonome (as I am not sure who is responsible for ipfs.io atm)