Skip to content

[ipfs/go-bitswap] Cleanup usage of processes and contexts #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Stebalien opened this issue Apr 9, 2020 · 2 comments · Fixed by #710
Closed

[ipfs/go-bitswap] Cleanup usage of processes and contexts #130

Stebalien opened this issue Apr 9, 2020 · 2 comments · Fixed by #710

Comments

@Stebalien
Copy link
Member

We should never pass around both a context and a goprocess.
@Stebalien
Copy link
Member Author

For example, the engine task workers should not be receiving both.

@Jorropo Jorropo changed the title Cleanup usage of processes and contexts [ipfs/go-bitswap] Cleanup usage of processes and contexts Jan 27, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-bitswap Jan 27, 2023
@guseggert guseggert reopened this Mar 27, 2023
@gammazero gammazero mentioned this issue Jan 21, 2025
Merged
@gammazero
Copy link
Contributor

Fixed in #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on goprocess ipfs/boxo
3 participants
@Stebalien @guseggert @gammazero