fix(dns): allow http:// DoH resolvers

lidel · lidel · commit f73689504bdd · 2024-07-29T23:28:30.000+02:00
allows people to run own DoH resolver on the same box
or within same secure VLAN/VPN/infra
diff --git a/gateway/dns.go b/gateway/dns.go
@@ -15,8 +15,8 @@ var defaultResolvers = map[string]string{
 }
 
 func newResolver(url string, opts ...doh.Option) (madns.BasicResolver, error) {
-	if !strings.HasPrefix(url, "https://") {
-		return nil, fmt.Errorf("invalid resolver url: %s", url)
+	if !strings.HasPrefix(url, "https://") && !strings.HasPrefix(url, "http://") {
+		return nil, fmt.Errorf("invalid DoH resolver URL: %s", url)
 	}
 
 	return doh.NewResolver(url, opts...)

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,8 @@ var defaultResolvers = map[string]string{`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`func newResolver(url string, opts ...doh.Option) (madns.BasicResolver, error) {`
`18`		`- if !strings.HasPrefix(url, "https://") {`
`19`		`- return nil, fmt.Errorf("invalid resolver url: %s", url)`
	`18`	`+ if !strings.HasPrefix(url, "https://") && !strings.HasPrefix(url, "http://") {`
	`19`	`+ return nil, fmt.Errorf("invalid DoH resolver URL: %s", url)`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`return doh.NewResolver(url, opts...)`