Skip to content

Commit a3da241

Browse files
authored
Minor spelling and wording changes (#768)
This is an accumulation of minor spelling and wording changes. Closes #766
1 parent 3cee549 commit a3da241

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ The following emojis are used to highlight certain changes:
5151
- `gateway`: `NewCacheBlockStore` and `NewCarBackend` will use `prometheus.DefaultRegisterer` when a custom one is not specified via `WithPrometheusRegistry` [#722](https://github.com/ipfs/boxo/pull/722)
5252
- `filestore`: added opt-in `WithMMapReader` option to `FileManager` to enable memory-mapped file reads [#665](https://github.com/ipfs/boxo/pull/665)
5353
- `bitswap/routing` `ProviderQueryManager` does not require calling `Startup` separate from `New`. [#741](https://github.com/ipfs/boxo/pull/741)
54-
- `bitswap/routing` ProviderQueryManager does not use liftcycle context.
54+
- `bitswap/routing` ProviderQueryManager does not use lifecycle context.
5555

5656
### Changed
5757

5858
- `bitswap`, `routing`, `exchange` ([#641](https://github.com/ipfs/boxo/pull/641)):
59-
- ✨ Bitswap is no longer in charge of providing blocks to the newtork: providing functionality is now handled by a `exchange/providing.Exchange`, meant to be used with `provider.System` so that all provides follow the same rules (multiple parts of the code where handling provides) before.
59+
- ✨ Bitswap is no longer in charge of providing blocks to the network: providing functionality is now handled by a `exchange/providing.Exchange`, meant to be used with `provider.System` so that all provides follow the same rules (multiple parts of the code where handling provides) before.
6060
- 🛠 `bitswap/client/internal/providerquerymanager` has been moved to `routing/providerquerymanager` where it belongs. In order to keep compatibility, Bitswap now receives a `routing.ContentDiscovery` parameter which implements `FindProvidersAsync(...)` and uses it to create a `providerquerymanager` with the default settings as before. Custom settings can be used by using a custom `providerquerymanager` to manually wrap a `ContentDiscovery` object and pass that in as `ContentDiscovery` on initialization while setting `bitswap.WithDefaultProviderQueryManager(false)` (to avoid re-wrapping it again).
6161
- The renovated `providedQueryManager` will trigger lookups until it manages to connect to `MaxProviders`. Before it would lookup at most `MaxInProcessRequests*MaxProviders` and connection failures may have limited the actual number of providers found.
6262
- 🛠 We have aligned our routing-related interfaces with the libp2p [`routing`](https://pkg.go.dev/github.com/libp2p/go-libp2p/core/routing#ContentRouting) ones, including in the `reprovider.System`.
63-
- In order to obtain exactly the same behaviour as before (i.e. particularly ensuring that new blocks are still provided), what was done like:
63+
- In order to obtain exactly the same behavior as before (i.e. particularly ensuring that new blocks are still provided), what was done like:
6464

6565
```go
6666
bswapnet := network.NewFromIpfsHost(host, contentRouter)
@@ -247,7 +247,7 @@ The following emojis are used to highlight certain changes:
247247

248248
### Fixed
249249

250-
- 🛠️`routing/http/server`: delegated peer routing endpoint now supports both [PeerID string notaitons from libp2p specs](https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#string-representation).
250+
- 🛠️`routing/http/server`: delegated peer routing endpoint now supports both [Peer ID string notations from libp2p specs](https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#string-representation).
251251
- `bitswap`: add missing client `WithBlockReceivedNotifier` and `WithoutDuplicatedBlockStats` options to the exchange.
252252

253253
## [v0.18.0]

bitswap/server/internal/decision/scoreledger.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ type DefaultScoreLedger struct {
109109
scorePeer ScorePeerFunc
110110
// is closed on Close
111111
closing chan struct{}
112-
// protects the fields immediatly below
112+
// protects the fields immediately below
113113
lock sync.RWMutex
114114
// ledgerMap lists score ledgers by their partner key.
115115
ledgerMap map[peer.ID]*scoreledger

mfs/dir.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ var (
2929
type Directory struct {
3030
inode
3131

32-
// Internal cache with added entries to the directory, its cotents
32+
// Internal cache with added entries to the directory, its contents
3333
// are synched with the underlying `unixfsDir` node in `sync()`.
3434
entriesCache map[string]FSNode
3535

0 commit comments

Comments
 (0)