fix(bitswap/session): cleanup live wants on cancel

Wondertan · Wondertan · commit 1e02fa071c95 · 2024-10-16T22:55:34.000+02:00
Otherwise live wants get rebroadcasted/requested forever, even when we cancelled those.
diff --git a/bitswap/client/internal/session/sessionwants.go b/bitswap/client/internal/session/sessionwants.go
@@ -148,6 +148,7 @@ func (sw *sessionWants) PrepareBroadcast() []cid.Cid {
 func (sw *sessionWants) CancelPending(keys []cid.Cid) {
 	for _, k := range keys {
 		sw.toFetch.Remove(k)
+		delete(sw.liveWants, k)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ func (sw *sessionWants) PrepareBroadcast() []cid.Cid {`
`148`	`148`	`func (sw *sessionWants) CancelPending(keys []cid.Cid) {`
`149`	`149`	`for _, k := range keys {`
`150`	`150`	`sw.toFetch.Remove(k)`
	`151`	`+ delete(sw.liveWants, k)`
`151`	`152`	`}`
`152`	`153`	`}`
`153`	`154`